summaryrefslogtreecommitdiffstats
path: root/ldap/servers/plugins/chainingdb/cb_utils.c
diff options
context:
space:
mode:
authorRich Megginson <rmeggins@redhat.com>2010-10-01 16:38:04 -0600
committerRich Megginson <rmeggins@redhat.com>2010-10-01 17:01:57 -0600
commit4f410d762b008da8e2e43e29100c2c04ff332fbb (patch)
tree6723ef832b034bda64cc691d252b42e522718bfa /ldap/servers/plugins/chainingdb/cb_utils.c
parenta82f61269d69882d19b15def70de68906ed5740e (diff)
downloadds-4f410d762b008da8e2e43e29100c2c04ff332fbb.tar.gz
ds-4f410d762b008da8e2e43e29100c2c04ff332fbb.tar.xz
ds-4f410d762b008da8e2e43e29100c2c04ff332fbb.zip
openldap ber_init will assert if the bv->bv_val is NULL
Have to ensure that all usage of ber_init in the server checks to see if the bv->bv_val is non-NULL before using ber_init, and return the appropriate error if it is NULL Also fixed a problem in dna_extend_exop - would not send the ldap result to the client in certain error conditions Reviewed by: nhosoi (Thanks!) Tested on: RHEL5 x86_64
Diffstat (limited to 'ldap/servers/plugins/chainingdb/cb_utils.c')
-rw-r--r--ldap/servers/plugins/chainingdb/cb_utils.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/ldap/servers/plugins/chainingdb/cb_utils.c b/ldap/servers/plugins/chainingdb/cb_utils.c
index 4878e1a8..cfa19a16 100644
--- a/ldap/servers/plugins/chainingdb/cb_utils.c
+++ b/ldap/servers/plugins/chainingdb/cb_utils.c
@@ -147,7 +147,8 @@ int cb_forward_operation(Slapi_PBlock * pb ) {
struct berval *ctl_value=NULL;
int iscritical=0;
- if (slapi_control_present(ctrls,CB_LDAP_CONTROL_CHAIN_SERVER,&ctl_value,&iscritical)) {
+ if (slapi_control_present(ctrls,CB_LDAP_CONTROL_CHAIN_SERVER,&ctl_value,&iscritical) &&
+ ctl_value && ctl_value->bv_val) {
/* Decode control data */
/* hop INTEGER (0 .. maxInt) */