diff options
| author | Rich Megginson <rmeggins@redhat.com> | 2010-06-30 10:43:20 -0600 |
|---|---|---|
| committer | Rich Megginson <rmeggins@redhat.com> | 2010-07-01 15:49:28 -0600 |
| commit | 99fa0c1363c32a2e3352c07be4b5aae751018d23 (patch) | |
| tree | 1f485ed5f22f68503e2da0631c896d406372e97f | |
| parent | e4ca30c3b247073c0a31a7ba1b356a5b7beb01b4 (diff) | |
| download | ds-99fa0c1363c32a2e3352c07be4b5aae751018d23.tar.gz ds-99fa0c1363c32a2e3352c07be4b5aae751018d23.tar.xz ds-99fa0c1363c32a2e3352c07be4b5aae751018d23.zip | |
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
https://bugzilla.redhat.com/show_bug.cgi?id=609590
Resolves: bug 609590
Bug Description: fix coverity Defect Type: Memory - corruptions issues
Reviewed by: nhosoi (Thanks!)
Branch: HEAD
Fix Description: The cnt parameter is not used, so just get rid of it.
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no
| -rw-r--r-- | ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c index 2858f5b1..e2138ebf 100644 --- a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c +++ b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c @@ -2436,7 +2436,7 @@ ldbm_exclude_attr_from_export( struct ldbminfo *li , const char *attr, */ void upgradedb_core(Slapi_PBlock *pb, ldbm_instance *inst); -int upgradedb_copy_logfiles(struct ldbminfo *li, char *destination_dir, int restore, int *cnt); +int upgradedb_copy_logfiles(struct ldbminfo *li, char *destination_dir, int restore); int upgradedb_delete_indices_4cmd(ldbm_instance *inst, int flags); static void normalize_dir(char *dir); @@ -2649,7 +2649,7 @@ int ldbm_back_upgradedb(Slapi_PBlock *pb) } /* copy checkpoint logs */ - backup_rval += upgradedb_copy_logfiles(li, dest_dir, 0, &cnt); + backup_rval += upgradedb_copy_logfiles(li, dest_dir, 0); if (run_from_cmdline) ldbm_config_internal_set(li, CONFIG_DB_TRANSACTION_LOGGING, "off"); @@ -2769,7 +2769,7 @@ fail1: inst_obj = objset_next_obj(li->li_instance_set, inst_obj); } - backup_rval = upgradedb_copy_logfiles(li, dest_dir, 1, &cnt); + backup_rval = upgradedb_copy_logfiles(li, dest_dir, 1); if (backup_rval < 0) slapi_log_error(SLAPI_LOG_FATAL, "upgrade DB", "Failed to restore log files.\n"); @@ -2809,7 +2809,7 @@ normalize_dir(char *dir) #define LOG "log." #define LOGLEN 4 int upgradedb_copy_logfiles(struct ldbminfo *li, char *destination_dir, - int restore, int *cnt) + int restore) { PRDir *dirhandle = NULL; PRDirEntry *direntry = NULL; @@ -2823,7 +2823,6 @@ int upgradedb_copy_logfiles(struct ldbminfo *li, char *destination_dir, char *from = NULL; char *to = NULL; - *cnt = 0; if (restore) { src = destination_dir; @@ -2888,7 +2887,6 @@ int upgradedb_copy_logfiles(struct ldbminfo *li, char *destination_dir, rval = dblayer_copyfile(from, to, 1, DEFAULT_MODE); if (rval < 0) break; - cnt++; } } slapi_ch_free_string(&from); |