diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-02 11:02:07 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:21:52 -0700 |
| commit | 92bf4eb29d084d72ab55c09f830f62fd4aadce2d (patch) | |
| tree | 7a68cfa20837296713fcf590e66b848533f7676d | |
| parent | de66a9e1a83ca5f9dacbfc87bf944ebaa8291058 (diff) | |
| download | ds-92bf4eb29d084d72ab55c09f830f62fd4aadce2d.tar.gz ds-92bf4eb29d084d72ab55c09f830f62fd4aadce2d.tar.xz ds-92bf4eb29d084d72ab55c09f830f62fd4aadce2d.zip | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11798 DEADCODE Triaged Unassigned Bug Moderate Fix Required
cb_sasl_bind_once_s() ds/ldap/servers/plugins/chainingdb/cb_bind.c
Comment:
This is not a DEADCODE problem, but a half-baked implementation
considering this comment:
190 /* realloc matcheddn & errmsg because the mem alloc model */
191 /* may differ from malloc
The author intended this:
184 rc = ldap_parse_result( ld, result, status, &matcheddnp2, &errmsgp2,
185 &referrals, resctrlsp, 1 );
| -rw-r--r-- | ldap/servers/plugins/chainingdb/cb_bind.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/chainingdb/cb_bind.c b/ldap/servers/plugins/chainingdb/cb_bind.c index 638404a6..71d1aded 100644 --- a/ldap/servers/plugins/chainingdb/cb_bind.c +++ b/ldap/servers/plugins/chainingdb/cb_bind.c @@ -181,7 +181,7 @@ cb_sasl_bind_once_s( cb_conn_pool *pool, char *dn, int method, char * mechanism, char * matcheddnp2, * errmsgp2; matcheddnp2=errmsgp2=NULL; *resctrlsp=NULL; - rc = ldap_parse_result( ld, result, status, matcheddnp, errmsgp, + rc = ldap_parse_result( ld, result, status, &matcheddnp2, &errmsgp2, &referrals, resctrlsp, 1 ); if ( referrals != NULL ) { *refurlsp = referrals2berval( referrals ); |