diff options
| author | Nathan Kinder <nkinder@redhat.com> | 2010-09-17 14:37:47 -0700 |
|---|---|---|
| committer | Nathan Kinder <nkinder@redhat.com> | 2010-09-17 14:37:47 -0700 |
| commit | 6b3b9009af5c85b0be9dea36aca86c93972a20a4 (patch) | |
| tree | 6c9dc2f2bdc10a44df3da0d7e69a51a3638cc953 | |
| parent | e1702b5a0442013d829eb6e1f4a4c1b7eeb71516 (diff) | |
| download | ds-6b3b9009af5c85b0be9dea36aca86c93972a20a4.tar.gz ds-6b3b9009af5c85b0be9dea36aca86c93972a20a4.tar.xz ds-6b3b9009af5c85b0be9dea36aca86c93972a20a4.zip | |
Bug 630092 - (cov#12105) Resource leak in pwdscheme config code
We don't free new_scheme if the password encode function is not
set. We need to free new_scheme in this error case.
| -rw-r--r-- | ldap/servers/slapd/libglobs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c index f36588cb..b88a69a8 100644 --- a/ldap/servers/slapd/libglobs.c +++ b/ldap/servers/slapd/libglobs.c @@ -1600,7 +1600,6 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf, } retVal = LDAP_OPERATIONS_ERROR; slapi_ch_free_string(&scheme_list); - free_pw_scheme(new_scheme); return retVal; } else if ( new_scheme->pws_enc == NULL ) @@ -1616,6 +1615,7 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf, } retVal = LDAP_UNWILLING_TO_PERFORM; slapi_ch_free_string(&scheme_list); + free_pw_scheme(new_scheme); return retVal; } |