diff options
author | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-10 11:32:06 -0700 |
---|---|---|
committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-11 10:40:07 -0700 |
commit | 5543a6e8200849dabc1b15e71f0911d678ce014a (patch) | |
tree | b44c1dd01dc67d9f28aab5056383498ef6473ccb | |
parent | 100785aae13a423f1c4522fccc8a753f60695bda (diff) | |
download | ds-5543a6e8200849dabc1b15e71f0911d678ce014a.tar.gz ds-5543a6e8200849dabc1b15e71f0911d678ce014a.tar.xz ds-5543a6e8200849dabc1b15e71f0911d678ce014a.zip |
Bug 622903 - fix coverity Defect Type: Code maintainability issues
https://bugzilla.redhat.com/show_bug.cgi?id=622903
Comment:
The str assignment on line 1240 can be removed because the value
is not needed or will be overwritten.
-rw-r--r-- | ldap/servers/plugins/acl/aclutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/acl/aclutil.c b/ldap/servers/plugins/acl/aclutil.c index c0b8f579..4fe0f686 100644 --- a/ldap/servers/plugins/acl/aclutil.c +++ b/ldap/servers/plugins/acl/aclutil.c @@ -1237,7 +1237,7 @@ acl_replace_str(char * s, char *substr, char* replace_with_str) { char *working_s, *suffix, *prefix, *patched; int replace_with_len, substr_len, prefix_len, suffix_len; - if ( (str = strstr(s, substr)) == NULL) { + if (strstr(s, substr) == NULL) { return(slapi_ch_strdup(s)); } else { |