diff options
| author | Nathan Kinder <nkinder@redhat.com> | 2010-09-14 11:27:44 -0700 |
|---|---|---|
| committer | Nathan Kinder <nkinder@redhat.com> | 2010-09-15 09:11:05 -0700 |
| commit | 30d6b1ea5c6a7f1f774bb86bea0d995cd9e45f20 (patch) | |
| tree | ae2663a8506a6882223c341936047921082d06c6 | |
| parent | 94b265fb509ac194dec8e51b6d02f7fd88673aac (diff) | |
| download | ds-30d6b1ea5c6a7f1f774bb86bea0d995cd9e45f20.tar.gz ds-30d6b1ea5c6a7f1f774bb86bea0d995cd9e45f20.tar.xz ds-30d6b1ea5c6a7f1f774bb86bea0d995cd9e45f20.zip | |
Bug 630097 - (cov#15463) Remove NULL check in referint plugin
Coverity believes that search_result_pb can be NULL since we check
if it is NULL before freeing the internal search results. If this
was true, there would be a NULL dereference issue when we call
slapi_pblock_get(). We are guaranteed that search_result_pb is
non-NULL after slapi_pblock_new() is called since the server would
exit if it was unable to allocate memory.
We should remove the NULL check before freeing the internal search
results.
| -rw-r--r-- | ldap/servers/plugins/referint/referint.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c index 32249e93..e22a0182 100644 --- a/ldap/servers/plugins/referint/referint.c +++ b/ldap/servers/plugins/referint/referint.c @@ -769,9 +769,7 @@ update_integrity(char **argv, char *origDN, slapi_ch_free_string(&filter); } - if (search_result_pb) { - slapi_free_search_results_internal(search_result_pb); - } + slapi_free_search_results_internal(search_result_pb); } } /* if got here, then everything good rc = 0 */ |