From 30d6b1ea5c6a7f1f774bb86bea0d995cd9e45f20 Mon Sep 17 00:00:00 2001 From: Nathan Kinder Date: Tue, 14 Sep 2010 11:27:44 -0700 Subject: Bug 630097 - (cov#15463) Remove NULL check in referint plugin Coverity believes that search_result_pb can be NULL since we check if it is NULL before freeing the internal search results. If this was true, there would be a NULL dereference issue when we call slapi_pblock_get(). We are guaranteed that search_result_pb is non-NULL after slapi_pblock_new() is called since the server would exit if it was unable to allocate memory. We should remove the NULL check before freeing the internal search results. --- ldap/servers/plugins/referint/referint.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c index 32249e93..e22a0182 100644 --- a/ldap/servers/plugins/referint/referint.c +++ b/ldap/servers/plugins/referint/referint.c @@ -769,9 +769,7 @@ update_integrity(char **argv, char *origDN, slapi_ch_free_string(&filter); } - if (search_result_pb) { - slapi_free_search_results_internal(search_result_pb); - } + slapi_free_search_results_internal(search_result_pb); } } /* if got here, then everything good rc = 0 */ -- cgit