| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
It is slightly dangerous to use @PATTERNS@, since these might
be substituted by autoconf when they appear in Makefile.am files.
(cherry picked from commit 4a4ca0c01da3307b69fc4925c5f2ece1e728d4b3)
|
| |
|
|
|
|
|
|
| |
This had accreted over a long period of time, so it wasn't
arranged very logically.
(cherry picked from commit 572291c64ed79b4988de6d23c31458d7c3c71b1d)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(RHBZ#858128).
If compare_device_names was given two devices with devices with
different interfaces (eg. /dev/sda and /dev/vda) then it would try to
compare the partition numbers, and fail when it could parse them.
It's arguable what we should be doing in this case (except for
strongly discouraging people from using the interface feature), but
let's at least not cause the daemon to assert-fail.
Found by Red Hat QA, thanks Mohua Li.
(cherry picked from commit 6f53d49a27fbf7f1b5c22080e2509375e128d5e4)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't assume that if guestfs_case_sensitive_path returns NULL, that it
means the file does not exist.
The (previously undefined) behaviour of case_sensitive_path was that a
NULL return meant "either the file doesn't exist or some other error".
However in commit 973581780d8a006f336684fef6762801402d775d this was
changed so that if the last element of the path didn't exist, it was
assumed to be a new file and the (non-NULL) path of the new file is
returned.
This change breaks code (including in libguestfs) which tries to use
case_sensitive_path as a dual-purpose call to fix-up a path for
Windows and test if the file exists. Such code should be rewritten so
that it explicitly tests for file existence after calling
case_sensitive_path.
I examined all the calls to case_sensitive_path in libguestfs and
modified them where necessary.
Cherry picked from commit 9ea6e9701461e594033999150f930cc4fafec4d2.
|
|
|
|
|
|
|
|
| |
The 'windows_path' function was blindly copied from virt-cat. In
virt-cat, errors are checked by the caller to 'windows_path'. But
virt-edit lacks this check. Change the function in virt-edit to add a
check and exit on error.
(cherry picked from commit 55b7c4df7895b8c22d737723d857a9a63db69926)
|
|
|
|
| |
(cherry picked from commit f7e138835a7194135113088767c46df65dbf292a)
|
|
|
|
|
|
|
|
| |
Everyone ignores the documentation. Everyone ignores me even
when I specifically tell them to include the complete output.
Place a prominent notice at the beginning of the output.
(cherry picked from commit 4f3048c6be0663c6c254a765ec5f83a7b40a8808)
|
|
|
|
|
|
| |
It would almost certainly indicate a bug if it happens, but
don't rely on printf not segfaulting if it did happen.
(cherry picked from commit ca2e65275d797864d2a5b3b3d0e115460522e5bb)
|
|
|
|
| |
(cherry picked from commit 9b7813c5bd91d53e358deee64ab42b00b42c37ba)
|
|
|
|
|
|
|
| |
"h" option is not enabled in virt-cat, remove it.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit f7f746a98e8d378ac8934a7f7b82a48b3e2a5aa4)
|
|
|
|
|
|
|
|
| |
- Use S<...> for non-breaking spaces.
- Arrange the builds section better.
- Add a section on enabling sVirt.
- Other small fixes.
(cherry picked from commit 19b29c36370beb76fd3f3a1f45289ce34c03e3c3)
|
|
|
|
| |
(cherry picked from commit d19e557df54f3822d38621b8c2da098bf44b4d53)
|
|
|
|
| |
(cherry picked from commit db6a8512402f068815f882928662af0d8f5eec83)
|
|
|
|
| |
(cherry picked from commit a95d4261b8cedc31bfc3c5358be7b346b27d457b)
|
|
|
|
| |
(cherry picked from commit 09c372ea250e8241d62e9fde70eabe7bdca83050)
|
|
|
|
| |
(cherry picked from commit 71f87d9a8f04212fc0534b3fb423780185181585)
|
|
|
|
|
|
|
| |
match will expand to guestfs___match, rename the local variable to avoid clash.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
(cherry picked from commit b36b44af9e177fe5c9677d430abc7cba0633049c)
|
|
|
|
|
| |
Cherry picked from commit 64cc0dafd03bb23ef1520c8f46fd2dd44a0d8c4e.
Remove ref to guestfs-release-notes(1) which doesn't exist in 1.18.
|
|
|
|
| |
(cherry picked from commit 8aa8eb205b02e1014e5ed9577f4a9da9fd864aba)
|
|
|
|
|
|
|
|
|
|
| |
Since this is the most common error seen by people who have
installation problems, buggy qemu, etc, and since no one reads the
FAQ, describe in this error message what resources are available to
debug launch problems.
Cherry picked from commit 840deea12079b05a9f588016af273843d5d6e1b8
and fixed for the stable branch.
|
|
|
|
| |
(cherry picked from commit 88c406feba1390f830c20bfb4c11989a4e877b91)
|
| |
|
|
|
|
| |
(cherry picked from commit 157b5006dbf2db2927e48ce592a83a279513d183)
|
|
|
|
| |
(cherry picked from commit 7e4b197cb6a5071c13e407546a21f9b93fe3798d)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, argument declarations were handled
inconsistently for strings and non-string arguments.
Non-string arguments were all declared at the top of the
function stub, where as string arguments were declared
in place.
Be consistent.
This is just code motion.
(cherry picked from commit c387b69cba8f145438188b2b4567abbc9580ade0)
|
|
|
|
|
|
|
| |
* cfg.mk (sc_prohibit_trailing_blank_lines): Remove rule. It is now
subsumed by the much more efficient sc_prohibit_empty_lines_at_EOF
rule in gnulib's maint.mk.
(cherry picked from commit 176bd182d3f94fe7e774b8af0b56c014f639d6c7)
|
|
|
|
|
| |
(thanks Jim Meyering).
(cherry picked from commit 3988dec9b7bbf3cb8628aff879d1f518a9d52404)
|
|
|
|
|
|
| |
We use strncpy, justifiably, to copy the socket name into
the fixed length Unix domain sun_path buffer.
(cherry picked from commit 72ab351acef2f2bc6b0e4f36d69e94f8fa064f3c)
|
|
|
|
| |
(cherry picked from commit 369709177e47773eaa37f1fdbe8d9967b21d1133)
|
|
|
|
|
|
| |
(thanks Jim Meyering).
(cherry picked from commit 552576c7f9ccb1862bcfc9fbd5c301d775aaf90c)
|
|
|
|
| |
(cherry picked from commit 2100ba14fbfaf3e89059d9112959463506932d74)
|
|
|
|
|
|
|
|
|
| |
Meyering).
The gnulib <fcntl.h> replacement header will now define this symbol if
it's not defined already.
(cherry picked from commit cb13ffe190ac41a9b77fe27521838f495c1a5077)
|
|
|
|
|
|
| |
Jim Meyering).
(cherry picked from commit 2337b9ccd729e05b46cf6abb1f4173e6e994c1cb)
|
|
|
|
| |
(cherry picked from commit fbdcfe2b77b6c272876143779912d41b0849111f)
|
|
|
|
| |
(cherry picked from commit b95fff13577cdd3da4300bbd639441cc77cf935a)
|
|
|
|
| |
(cherry picked from commit e942c02a2eeb4d55606dec5fe943ea7d81f989ba)
|
|
|
|
|
|
|
|
|
| |
This libguestfs 1.18-specific patch is necessary because something
(gcc? gnulib?) has enabled a strict -Wjump-misses-init warning, which
breaks libguestfs builds. In the development branch we fixed
everything (commit e128a627fb8f39f4f4c11b782cef895bd79f0282,
commit 74283d58cfb62e6cc73bfe0f62ca142ddc1e8fb2), but that patch is
too invasive to backport.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passing the $upstream_qemu environment variable is not reliable when
libvirt is involved: Environment variables are passed to the first
instance of the session libvirtd, but because libvirt reuses the
session libvirtd, subsequent environment variable settings are lost
(this is filed as RHBZ#856619).
Bypass all of this by writing a custom qemu-wrapper.sh which contains
the hard-coded values we want.
(cherry picked from commit e6bd0b87eb753fa96b6533b0dbe498697701ad3a)
|
|
|
|
| |
(cherry picked from commit 509dd90c43afed75b861b7d82ebe8739d3500d54)
|
|
|
|
| |
(cherry picked from commit eeb0c598ec8caa50998336713ed4e62902e0a74d)
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit 2cac8d490e9884a8c7376e49fd1cda2e3d3abec1)
|
|
|
|
|
|
| |
The correct way to extend functions is documented in generator/README.
This comment was no longer accurate.
(cherry picked from commit 44a11e955b31f7c0cf463a04d640263cccdd0c4d)
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit 6361810b53be4d5e0513b4f7c11d29cf1d6d3b45)
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit b0cefb417d01c6dcb87cc6bafe9c19b98c690c9d)
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit 90b7c53b70dda9a131cf13beb5d1e77cc41534f7)
|
|
|
|
|
|
|
| |
Found by 'make syntax-check'.
Cherry picked from commit a67129b0fb45b2f83eb711c6c599569d0f53e580
and modified for 1.18 branch.
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit d6bb49a172c369c3bcc85771af804649c3733ef3)
|
|
|
|
|
|
|
| |
Found by 'make syntax-check'.
Cherry picked from commit 9fce75aa13de52561ec0f4ae083c4ab0fa4455d1
and fixed for libguestfs 1.18 branch.
|
|
|
|
|
| |
Found by 'make syntax-check'.
(cherry picked from commit 6272e49f51a192f2f8ecd8ffbb018f60ca0bac28)
|