summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2012-06-28 13:15:57 +0100
committerRichard W.M. Jones <rjones@redhat.com>2012-06-28 13:19:39 +0100
commit927ef14c584524a16e8be3fb7eff6cd3ee880ce6 (patch)
tree53445bff704798cdde908fc7a8d4e19c257d56fd /tools
parentb3df3ba5c824dc5ea15902df2f1ee80254aca22f (diff)
downloadlibguestfs-927ef14c584524a16e8be3fb7eff6cd3ee880ce6.tar.gz
libguestfs-927ef14c584524a16e8be3fb7eff6cd3ee880ce6.tar.xz
libguestfs-927ef14c584524a16e8be3fb7eff6cd3ee880ce6.zip
run: Set MALLOC_PERTURB_ to a random value.
MALLOC_PERTURB_ is a glibc feature which causes malloc to wipe memory before and after it is used, allowing both use-after-free and uninitialized reads to be detected with relatively little performance penalty: http://udrepper.livejournal.com/11429.html?nojs=1 Modify the ./run script so that it always sets this. We were already using MALLOC_PERTURB_ in most tests. Since ./run is now setting this, we can remove it from individual Makefiles. Most TESTS_ENVIRONMENT will now simply look like this: TESTS_ENVIRONMENT = $(top_builddir)/run --test
Diffstat (limited to 'tools')
-rw-r--r--tools/Makefile.am6
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/Makefile.am b/tools/Makefile.am
index a5d9844c..2c2ad1f3 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -55,11 +55,7 @@ $(top_builddir)/html/virt-%.1.html: virt-%
# Tests.
-random_val := $(shell awk 'BEGIN{srand(); print 1+int(255*rand())}' < /dev/null)
-
-TESTS_ENVIRONMENT = \
- MALLOC_PERTURB_=$(random_val) \
- $(top_builddir)/run --test
+TESTS_ENVIRONMENT = $(top_builddir)/run --test
if ENABLE_APPLIANCE
TESTS = test-virt-list-filesystems.sh \