summaryrefslogtreecommitdiffstats
path: root/src/launch.c
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2012-09-20 11:41:16 +0100
committerRichard W.M. Jones <rjones@redhat.com>2012-10-01 15:02:22 +0100
commitd0b13a12b73bad3f409e4fc4f2cd3da6d32efdf1 (patch)
tree654a006d19d0bd8648faa115dfcdbaf085db8eaf /src/launch.c
parent6de97c002ab75ddaa80a8ab27a483fed7de32909 (diff)
downloadlibguestfs-d0b13a12b73bad3f409e4fc4f2cd3da6d32efdf1.tar.gz
libguestfs-d0b13a12b73bad3f409e4fc4f2cd3da6d32efdf1.tar.xz
libguestfs-d0b13a12b73bad3f409e4fc4f2cd3da6d32efdf1.zip
launch: Make the "launched failed" message more explanatory.
Since this is the most common error seen by people who have installation problems, buggy qemu, etc, and since no one reads the FAQ, describe in this error message what resources are available to debug launch problems. Cherry picked from commit 840deea12079b05a9f588016af273843d5d6e1b8 and fixed for the stable branch. Cherry picked from commit 58f190b2b8c507c6151fd86e6fef896f842b3e87.
Diffstat (limited to 'src/launch.c')
-rw-r--r--src/launch.c20
1 files changed, 18 insertions, 2 deletions
diff --git a/src/launch.c b/src/launch.c
index 8f6be68d..69e2a8fb 100644
--- a/src/launch.c
+++ b/src/launch.c
@@ -989,12 +989,12 @@ launch_appliance (guestfs_h *g)
free (buf);
if (r == -1) {
- error (g, _("guestfs_launch failed, see earlier error messages"));
+ guestfs___launch_failed_error (g);
goto cleanup1;
}
if (size != GUESTFS_LAUNCH_FLAG) {
- error (g, _("guestfs_launch failed, see earlier error messages"));
+ guestfs___launch_failed_error (g);
goto cleanup1;
}
@@ -1148,6 +1148,22 @@ guestfs___launch_send_progress (guestfs_h *g, int perdozen)
}
}
+/* Since this is the most common error seen by people who have
+ * installation problems, buggy qemu, etc, and since no one reads the
+ * FAQ, describe in this error message what resources are available to
+ * debug launch problems.
+ */
+void
+guestfs___launch_failed_error (guestfs_h *g)
+{
+ if (g->verbose)
+ error (g, _("guestfs_launch failed, see earlier error messages"));
+ else
+ error (g, _("guestfs_launch failed.\n"
+ "See http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs\n"
+ "and/or run 'libguestfs-test-tool'."));
+}
+
/* Return the location of the tmpdir (eg. "/tmp") and allow users
* to override it at runtime using $TMPDIR.
* http://www.pathname.com/fhs/pub/fhs-2.3.html#TMPTEMPORARYFILES