diff options
| author | Richard Jones <rjones@redhat.com> | 2010-07-22 14:39:36 +0100 |
|---|---|---|
| committer | Richard Jones <rjones@redhat.com> | 2010-08-17 16:01:40 +0100 |
| commit | 8f549bd20a193bc61c6e78019c55aeb2efeb7bda (patch) | |
| tree | 3380d0d6132c4cf434c07e18ab69c874a8152ec3 /src/guestfs-internal.h | |
| parent | 17de7c785c921aef542681ee66538508d270fdf3 (diff) | |
| download | libguestfs-8f549bd20a193bc61c6e78019c55aeb2efeb7bda.tar.gz libguestfs-8f549bd20a193bc61c6e78019c55aeb2efeb7bda.tar.xz libguestfs-8f549bd20a193bc61c6e78019c55aeb2efeb7bda.zip | |
Revert "add_drive_ro adds readonly=on option if available." (RHBZ#617200).
Adding the readonly=on option is not so clever. This causes
qemu to present the disk as read-only to the guest. (The
expected behaviour of snapshots=on,readonly=on was that it
would open the disk O_RDONLY but present a writable disk to
the guest).
Since the guest sees a read-only disk, we are unable to do any
recovery if a filesystem on the disk is inconsistent. This basically
prevents most accesses to live disk images.
What we really want is a qemu option which presents a writable
disk to the guest, but only opens the disk on the host side with
O_RDONLY, to alleviate the udev bug RHBZ#571714.
This reverts commit 676462684e05dd8341dd695762dd99a87d8ec022.
(cherry picked from commit 799d52be4f08f6c70c0e8ba1aa7367ba4cdd78c4)
Diffstat (limited to 'src/guestfs-internal.h')
0 files changed, 0 insertions, 0 deletions