summaryrefslogtreecommitdiffstats
path: root/daemon
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2011-06-08 22:01:41 +0100
committerRichard W.M. Jones <rjones@redhat.com>2011-06-09 10:53:22 +0100
commit3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7 (patch)
tree63239ef332bdce8e2a6e0fe16380e21a040e3b8f /daemon
parent48ebf50f3136ac27f4252662e351230ffa2b15e5 (diff)
downloadlibguestfs-3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7.tar.gz
libguestfs-3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7.tar.xz
libguestfs-3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7.zip
Coverity: Avoid calling sort_strings (NULL, 0) on empty list.
Diffstat (limited to 'daemon')
-rw-r--r--daemon/devsparts.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/daemon/devsparts.c b/daemon/devsparts.c
index 1781def3..c8f0256a 100644
--- a/daemon/devsparts.c
+++ b/daemon/devsparts.c
@@ -105,8 +105,9 @@ foreach_block_device (block_dev_func_t func)
return NULL;
}
- /* Sort the devices */
- sort_strings (r, size);
+ /* Sort the devices. Note that r might be NULL if there are no devices. */
+ if (r != NULL)
+ sort_strings (r, size);
/* NULL terminate the list */
if (add_string (&r, &size, &alloc, NULL) == -1) {