summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2011-05-08 15:13:23 +0100
committerRichard W.M. Jones <rjones@redhat.com>2011-05-18 11:40:31 +0100
commit7065a453cb09caa216924fd3d8cc913a48e0f942 (patch)
tree244466990aa3a769e5fe0dd3d59c1296c7e2a3d5
parent5f6abe882ded3b751c34932f397646468bcd93d8 (diff)
downloadlibguestfs-7065a453cb09caa216924fd3d8cc913a48e0f942.tar.gz
libguestfs-7065a453cb09caa216924fd3d8cc913a48e0f942.tar.xz
libguestfs-7065a453cb09caa216924fd3d8cc913a48e0f942.zip
Fix guestfs___rollback_cmdline when pos == 0.
Because of the previous change to size_t, when pos == 0 the loop would wrap around and cause a segmentation fault. This fixes a regression introduced by commit 10167cea98f93a74abe63f0a54d3a662997e7489. (cherry picked from commit 607aa95de927b5b8e4b212655c71bf21acbba372)
-rw-r--r--src/launch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/launch.c b/src/launch.c
index 8dfeb315..ecc0464a 100644
--- a/src/launch.c
+++ b/src/launch.c
@@ -117,7 +117,7 @@ guestfs___rollback_cmdline (guestfs_h *g, size_t pos)
assert (g->cmdline_size >= pos);
- for (i = g->cmdline_size - 1; i >= pos; --i)
+ for (i = pos; i < g->cmdline_size; ++i)
free (g->cmdline[i]);
g->cmdline_size = pos;