summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2011-11-24 14:39:10 +0000
committerRichard W.M. Jones <rjones@redhat.com>2011-11-24 21:07:06 +0000
commit7042c94a54b43a184f933e0cf8bbdf4846235474 (patch)
tree5ef037a1c3ac71ce87595385ef2707065604fe4b
parented628d30b05b4f5884f1d2029633cf155bf5e571 (diff)
downloadlibguestfs-7042c94a54b43a184f933e0cf8bbdf4846235474.tar.gz
libguestfs-7042c94a54b43a184f933e0cf8bbdf4846235474.tar.xz
libguestfs-7042c94a54b43a184f933e0cf8bbdf4846235474.zip
part-disk: Change default alignment of this to 64K (128 sectors).
This is the minimum alignment. 1MB would be better. Note that the exact behaviour is not defined in the API. (cherry picked from commit c4381dba737d5cb8aad8e1b2e2123b0fcaff1d1a)
-rw-r--r--daemon/parted.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/daemon/parted.c b/daemon/parted.c
index dbcae032..0d229484 100644
--- a/daemon/parted.c
+++ b/daemon/parted.c
@@ -184,15 +184,16 @@ do_part_disk (const char *device, const char *parttype)
return -1;
}
- /* Align all partitions created this way to 64 sectors, and leave
- * the last 64 sectors at the end of the disk free. This wastes
- * 32K+32K = 64K on 512-byte sector disks. The rationale is:
+ /* Align all partitions created this way to 128 sectors, and leave
+ * the last 128 sectors at the end of the disk free. This wastes
+ * 64K+64K = 128K on 512-byte sector disks. The rationale is:
*
* - aligned operations are faster
+ * - absolute minimum recommended alignment is 64K (1M would be better)
* - GPT requires at least 34 sectors at the end of the disk.
*/
- const char *startstr = "64s";
- const char *endstr = "-64s";
+ const char *startstr = "128s";
+ const char *endstr = "-128s";
RUN_PARTED (return -1,
device,