comment: Note time-of-check to time-of-use race found by Coverity.

1 files changed, 6 insertions, 0 deletions

diff --git a/daemon/file.c b/daemon/file.c
index 91746e0d..52354461 100644
--- a/daemon/file.c
+++ b/daemon/file.c
@@ -38,6 +38,12 @@ do_touch (const char *path)
 
   /* RHBZ#582484: Restrict touch to regular files.  It's also OK
    * here if the file does not exist, since we will create it.
+   *
+   * XXX Coverity flags this as a time-of-check to time-of-use race
+   * condition, particularly in the libguestfs live case.  Not clear
+   * how to fix this yet, since unconditionally opening the file can
+   * cause a hang, so you have to somehow check it first before you
+   * open it.
    */
   CHROOT_IN;
   r = lstat (path, &buf);