1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
|
if __FILE__ == $0
if Dir.getwd =~ /test\/server$/
Dir.chdir("..")
end
$:.unshift '../lib'
$puppetbase = ".."
end
require 'puppet'
require 'puppet/server/fileserver'
require 'test/unit'
require 'puppettest.rb'
class TestFileServer < Test::Unit::TestCase
include TestPuppet
# make a simple file source
def mktestdir
testdir = File.join(tmpdir(), "remotefilecopytesting")
@@tmpfiles << testdir
# create a tmpfile
pattern = "tmpfile"
tmpfile = File.join(testdir, pattern)
assert_nothing_raised {
Dir.mkdir(testdir)
File.open(tmpfile, "w") { |f|
3.times { f.puts rand(100) }
}
}
return [testdir, %r{#{pattern}}, tmpfile]
end
# make a bunch of random test files
def mktestfiles(testdir)
@@tmpfiles << testdir
assert_nothing_raised {
Dir.mkdir(testdir)
@@tmpfiles << testdir
files = %w{a b c d e}.collect { |l|
name = File.join(testdir, "file%s" % l)
File.open(name, "w") { |f|
f.puts rand(100)
}
name
}
return files
}
end
def assert_describe(base, file, server)
file = File.basename(file)
assert_nothing_raised {
desc = server.describe(base + file)
assert(desc, "Got no description for %s" % file)
assert(desc != "", "Got no description for %s" % file)
assert_match(/^\d+/, desc, "Got invalid description %s" % desc)
}
end
# test for invalid names
def test_namefailures
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
assert_raise(Puppet::Server::FileServerError) {
server.mount("/tmp", "invalid+name")
}
assert_raise(Puppet::Server::FileServerError) {
server.mount("/tmp", "invalid-name")
}
assert_raise(Puppet::Server::FileServerError) {
server.mount("/tmp", "invalid name")
}
assert_raise(Puppet::Server::FileServerError) {
server.mount("/tmp", "")
}
end
# verify that listing the root behaves as expected
def test_listroot
server = nil
testdir, pattern, tmpfile = mktestdir()
file = nil
checks = Puppet::Server::FileServer::CHECKPARAMS
# and make our fileserver
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
# mount the testdir
assert_nothing_raised {
server.mount(testdir, "test")
}
# and verify different iterations of 'root' return the same value
list = nil
assert_nothing_raised {
list = server.list("/test/", true, false)
}
assert(list =~ pattern)
assert_nothing_raised {
list = server.list("/test", true, false)
}
assert(list =~ pattern)
end
# test listing individual files
def test_getfilelist
server = nil
testdir, pattern, tmpfile = mktestdir()
file = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
assert_nothing_raised {
server.mount(testdir, "test")
}
# get our listing
list = nil
sfile = "/test/tmpfile"
assert_nothing_raised {
list = server.list(sfile, true, false)
}
assert_nothing_raised {
file = Puppet::Type::PFile[tmpfile]
}
output = "/\tfile"
# verify it got listed as a file
assert_equal(output, list)
# verify we got all fields
assert(list !~ /\t\t/)
# verify that we didn't get the directory itself
list.split("\n").each { |line|
assert(line !~ %r{remotefile})
}
# and then verify that the contents match
contents = File.read(tmpfile)
ret = nil
assert_nothing_raised {
ret = server.retrieve(sfile)
}
assert_equal(contents, ret)
end
# check that the fileserver is seeing newly created files
def test_seenewfiles
server = nil
testdir, pattern, tmpfile = mktestdir()
newfile = File.join(testdir, "newfile")
# go through the whole schtick again...
file = nil
checks = Puppet::Server::FileServer::CHECKPARAMS
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
assert_nothing_raised {
server.mount(testdir, "test")
}
list = nil
sfile = "/test/"
assert_nothing_raised {
list = server.list(sfile, true, false)
}
# create the new file
File.open(newfile, "w") { |f|
3.times { f.puts rand(100) }
}
newlist = nil
assert_nothing_raised {
newlist = server.list(sfile, true, false)
}
# verify the list has changed
assert(list != newlist)
# and verify that we are specifically seeing the new file
assert(newlist =~ /newfile/)
end
# verify we can mount /, which is what local file servers will
# normally do
def test_mountroot
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
assert_nothing_raised {
server.mount("/", "root")
}
testdir, pattern, tmpfile = mktestdir()
list = nil
assert_nothing_raised {
list = server.list("/root/" + testdir, true, false)
}
assert(list =~ pattern)
end
# verify that we're correctly recursing the right number of levels
def test_recursionlevels
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
# make our deep recursion
basedir = File.join(tmpdir(), "recurseremotetesting")
testdir = "%s/with/some/sub/directories/for/the/purposes/of/testing" % basedir
oldfile = File.join(testdir, "oldfile")
assert_nothing_raised {
system("mkdir -p %s" % testdir)
File.open(oldfile, "w") { |f|
3.times { f.puts rand(100) }
}
@@tmpfiles << basedir
}
assert_nothing_raised {
server.mount(basedir, "test")
}
# get our list
list = nil
assert_nothing_raised {
list = server.list("/test/with", false, false)
}
# make sure we only got one line, since we're not recursing
assert(list !~ /\n/)
# for each level of recursion, make sure we get the right list
[0, 1, 2].each { |num|
assert_nothing_raised {
list = server.list("/test/with", num, false)
}
count = 0
while list =~ /\n/
list.sub!(/\n/, '')
count += 1
end
assert_equal(num, count)
}
end
# verify that we're not seeing the dir we ask for; i.e., that our
# list is relative to that dir, not it's parent dir
def test_listedpath
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
# create a deep dir
basedir = "/tmp/remotefilecopying"
testdir = "%s/with/some/sub/directories/for/testing" % basedir
oldfile = File.join(testdir, "oldfile")
assert_nothing_raised {
system("mkdir -p %s" % testdir)
File.open(oldfile, "w") { |f|
3.times { f.puts rand(100) }
}
@@tmpfiles << basedir
}
# mounty mounty
assert_nothing_raised {
server.mount(basedir, "localhost")
}
list = nil
# and then check a few dirs
assert_nothing_raised {
list = server.list("/localhost/with", false, false)
}
assert(list !~ /with/)
assert_nothing_raised {
list = server.list("/localhost/with/some/sub", true, false)
}
assert(list !~ /sub/)
end
# test many dirs, not necessarily very deep
def test_widelists
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
basedir = "/tmp/remotefilecopying"
dirs = %w{a set of directories}
assert_nothing_raised {
Dir.mkdir(basedir)
dirs.each { |dir|
Dir.mkdir(File.join(basedir, dir))
}
@@tmpfiles << basedir
}
assert_nothing_raised {
server.mount(basedir, "localhost")
}
list = nil
assert_nothing_raised {
list = server.list("/localhost/", 1, false)
}
assert_instance_of(String, list, "Server returned %s instead of string")
list = list.split("\n")
assert_equal(dirs.length + 1, list.length)
end
# verify that 'describe' works as advertised
def test_describe
server = nil
testdir = "/tmp/remotefilecopying"
files = mktestfiles(testdir)
file = nil
checks = Puppet::Server::FileServer::CHECKPARAMS
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => false
)
}
assert_nothing_raised {
server.mount(testdir, "test")
}
# get our list
list = nil
sfile = "/test/"
assert_nothing_raised {
list = server.list(sfile, true, false)
}
# and describe each file in the list
assert_nothing_raised {
list.split("\n").each { |line|
file, type = line.split("\t")
desc = server.describe(sfile + file)
}
}
# and then make sure we can describe everything that we know is there
files.each { |file|
assert_describe(sfile, file, server)
}
# And then describe some files that we know aren't there
retval = nil
assert_nothing_raised("Describing non-existent files raised an error") {
retval = server.describe(sfile + "noexisties")
}
assert_equal("", retval, "Description of non-existent files returned a value")
# Now try to describe some sources that don't even exist
retval = nil
assert_raise(Puppet::Server::FileServerError,
"Describing non-existent mount did not raise an error") {
retval = server.describe("/notmounted/" + "noexisties")
}
assert_nil(retval, "Description of non-existent mounts returned a value")
end
# test that our config file is parsing and working as planned
def test_configfile
server = nil
basedir = File.join(tmpdir, "fileserverconfigfiletesting")
@@tmpfiles << basedir
# make some dirs for mounting
Dir.mkdir(basedir)
mounts = {}
%w{thing thus these those}.each { |dir|
path = File.join(basedir, dir)
mounts[dir] = mktestfiles(path)
}
# create an example file with each of them
conffile = tempfile
@@tmpfiles << conffile
File.open(conffile, "w") { |f|
f.print "# a test config file
[thing]
path #{basedir}/thing
allow 192.168.0.*
[thus]
path #{basedir}/thus
allow *.madstop.com, *.kanies.com
deny *.sub.madstop.com
[these]
path #{basedir}/these
[those]
path #{basedir}/those
"
}
# create a server with the file
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => conffile
)
}
list = nil
# run through once with no host/ip info, to verify everything is working
mounts.each { |mount, files|
mount = "/#{mount}/"
assert_nothing_raised {
list = server.list(mount, true, false)
}
assert_nothing_raised {
list.split("\n").each { |line|
file, type = line.split("\t")
desc = server.describe(mount + file)
}
}
files.each { |f|
assert_describe(mount, f, server)
}
}
# now let's check that things are being correctly forbidden
# this is just a map of names and expected results
{
"thing" => {
:deny => [
["hostname.com", "192.168.1.0"],
["hostname.com", "192.158.0.0"]
],
:allow => [
["hostname.com", "192.168.0.0"],
["hostname.com", "192.168.0.245"],
]
},
"thus" => {
:deny => [
["hostname.com", "192.168.1.0"],
["name.sub.madstop.com", "192.158.0.0"]
],
:allow => [
["luke.kanies.com", "192.168.0.0"],
["luke.madstop.com", "192.168.0.245"],
]
}
}.each { |mount, hash|
mount = "/#{mount}/"
# run through the map
hash.each { |type, ary|
ary.each { |sub|
host, ip = sub
case type
when :deny:
assert_raise(Puppet::Server::AuthorizationError,
"Host %s, ip %s, allowed %s" %
[host, ip, mount]) {
list = server.list(mount, true, false, host, ip)
}
when :allow:
assert_nothing_raised("Host %s, ip %s, denied %s" %
[host, ip, mount]) {
list = server.list(mount, true, false, host, ip)
}
end
}
}
}
end
# Test that we smoothly handle invalid config files
def test_configfailures
# create an example file with each of them
conffile = tempfile()
invalidmounts = {
"noexist" => "[noexist]
path /this/path/does/not/exist
allow 192.168.0.*
"
}
invalidconfigs = [
"[not valid]
path /this/path/does/not/exist
allow 192.168.0.*
",
"[valid]
invalidstatement
path /etc
allow 192.168.0.*
",
"[valid]
allow 192.168.0.*
"
]
invalidmounts.each { |mount, text|
File.open(conffile, "w") { |f|
f.print text
}
# create a server with the file
server = nil
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => conffile
)
}
assert_raise(Puppet::Server::FileServerError,
"Invalid mount was mounted") {
server.list(mount)
}
}
invalidconfigs.each_with_index { |text, i|
File.open(conffile, "w") { |f|
f.print text
}
# create a server with the file
server = nil
assert_raise(Puppet::Server::FileServerError,
"Invalid config %s did not raise error" % i) {
server = Puppet::Server::FileServer.new(
:Local => true,
:Config => conffile
)
}
}
end
# verify we reread the config file when it changes
def test_filereread
server = nil
dir = testdir()
files = mktestfiles(dir)
conffile = tempfile()
File.open(conffile, "w") { |f|
f.print "# a test config file
[thing]
path #{dir}
allow test1.domain.com
"
}
# start our server with a fast timeout
assert_nothing_raised {
server = Puppet::Server::FileServer.new(
:Local => true,
:ConfigTimeout => 0.5,
:Config => conffile
)
}
list = nil
assert_nothing_raised {
list = server.list("/thing/", false, false,
"test1.domain.com", "127.0.0.1")
}
assert(list != "", "List returned nothing in rereard test")
assert_raise(Puppet::Server::AuthorizationError, "List allowed invalid host") {
list = server.list("/thing/", false, false,
"test2.domain.com", "127.0.0.1")
}
sleep 1
File.open(conffile, "w") { |f|
f.print "# a test config file
[thing]
path #{dir}
allow test2.domain.com
"
}
assert_raise(Puppet::Server::AuthorizationError, "List allowed invalid host") {
list = server.list("/thing/", false, false,
"test1.domain.com", "127.0.0.1")
}
assert_nothing_raised {
list = server.list("/thing/", false, false,
"test2.domain.com", "127.0.0.1")
}
assert(list != "", "List returned nothing in rereard test")
list = nil
end
end
# $Id$
|