1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
|
#!/usr/bin/env ruby
require File.dirname(__FILE__) + '/../../lib/puppettest'
require 'puppettest'
# Test cron job creation, modification, and destruction
class TestCron < Test::Unit::TestCase
include PuppetTest
def setup
super
setme()
@crontype = Puppet::Type.type(:cron)
@provider = @crontype.defaultprovider
if @provider.respond_to?(:filetype=)
@provider.stubs(:filetype).returns(Puppet::Util::FileType.filetype(:ram))
end
@crontype = Puppet::Type.type(:cron)
end
def teardown
super
@crontype.defaultprovider = nil
end
def eachprovider
@crontype.suitableprovider.each do |provider|
yield provider
end
end
# Back up the user's existing cron tab if they have one.
def cronback
tab = nil
assert_nothing_raised {
tab = Puppet::Type.type(:cron).filetype.read(@me)
}
if $? == 0
@currenttab = tab
else
@currenttab = nil
end
end
# Restore the cron tab to its original form.
def cronrestore
assert_nothing_raised {
if @currenttab
@crontype.filetype.new(@me).write(@currenttab)
else
@crontype.filetype.new(@me).remove
end
}
end
# Create a cron job with all fields filled in.
def mkcron(name, addargs = true)
cron = nil
command = "date > %s/crontest%s" % [tmpdir(), name]
args = nil
if addargs
args = {
:command => command,
:name => name,
:user => @me,
:minute => rand(59),
:month => "1",
:monthday => "1",
:hour => "1"
}
else
args = {:command => command, :name => name}
end
assert_nothing_raised {
cron = @crontype.new(args)
}
return cron
end
# Run the cron through its paces -- install it then remove it.
def cyclecron(cron)
obj = Puppet::Type::Cron.cronobj(@me)
text = obj.read
name = cron.name
comp = mk_catalog(name, cron)
assert_events([:cron_created], comp)
cron.provider.class.prefetch
currentvalue = cron.retrieve
assert(cron.insync?(currentvalue), "Cron is not in sync")
assert_events([], comp)
curtext = obj.read
text.split("\n").each do |line|
assert(curtext.include?(line), "Missing '%s'" % line)
end
obj = Puppet::Type::Cron.cronobj(@me)
cron[:ensure] = :absent
assert_events([:cron_removed], comp)
cron.provider.class.prefetch
currentvalue = cron.retrieve
assert(cron.insync?(currentvalue), "Cron is not in sync")
assert_events([], comp)
end
# Test that a cron job with spaces at the end doesn't get rewritten
def test_trailingspaces
eachprovider do |provider|
cron = nil
# make the cron
name = "yaytest"
command = "date > /dev/null "
assert_nothing_raised {
cron = @crontype.new(
:name => name,
:command => "date > /dev/null ",
:month => "May",
:user => @me
)
}
property = cron.send(:property, :command)
cron.provider.command = command
cron.provider.ensure = :present
cron.provider.user = @me
cron.provider.month = ["4"]
cron.provider.class.prefetch
currentvalue = cron.retrieve
assert(cron.parameter(:command).insync?(currentvalue[:command]), "Property :command is not considered in sync with value #{currentvalue[:command]}")
end
end
def test_makeandretrievecron
%w{storeandretrieve a-name another-name more_naming SomeName}.each do |name|
cron = mkcron(name)
catalog = mk_catalog(name, cron)
trans = assert_events([:cron_created], catalog, name)
cron.provider.class.prefetch
cron = nil
assert(cron = catalog.resource(:cron, name), "Could not retrieve named cron")
assert_instance_of(Puppet::Type.type(:cron), cron)
end
end
# Do input validation testing on all of the parameters.
def test_arguments
values = {
:monthday => {
:valid => [ 1, 13, "1" ],
:invalid => [ -1, 0, 32 ]
},
:weekday => {
:valid => [ 0, 3, 6, "1", "tue", "wed",
"Wed", "MOnday", "SaTurday" ],
:invalid => [ -1, 8, "13", "tues", "teusday", "thurs" ]
},
:hour => {
:valid => [ 0, 21, 23 ],
:invalid => [ -1, 24 ]
},
:minute => {
:valid => [ 0, 34, 59 ],
:invalid => [ -1, 60 ]
},
:month => {
:valid => [ 1, 11, 12, "mar", "March", "apr", "October", "DeCeMbEr" ],
:invalid => [ -1, 0, 13, "marc", "sept" ]
}
}
cron = mkcron("valtesting")
values.each { |param, hash|
# We have to test the valid ones first, because otherwise the
# property will fail to create at all.
[:valid, :invalid].each { |type|
hash[type].each { |value|
case type
when :valid
assert_nothing_raised {
cron[param] = value
}
if value.is_a?(Integer)
assert_equal([value.to_s], cron.should(param),
"Cron value was not set correctly")
end
when :invalid
assert_raise(Puppet::Error, "%s is incorrectly a valid %s" %
[value, param]) {
cron[param] = value
}
end
if value.is_a?(Integer)
value = value.to_s
redo
end
}
}
}
end
# Verify that comma-separated numbers are not resulting in rewrites
def test_comma_separated_vals_work
eachprovider do |provider|
cron = nil
assert_nothing_raised {
cron = @crontype.new(
:command => "/bin/date > /dev/null",
:minute => [0, 30],
:name => "crontest",
:provider => provider.name
)
}
cron.provider.ensure = :present
cron.provider.command = '/bin/date > /dev/null'
cron.provider.minute = %w{0 30}
cron.provider.class.prefetch
currentvalue = cron.retrieve
currentvalue.each do |name, value|
# We're only interested in comparing minutes.
next unless name.to_s == "minute"
assert(cron.parameter(name).insync?(value), "Property #{name} is not considered in sync with value #{value.inspect}")
end
end
end
def test_fieldremoval
cron = nil
assert_nothing_raised {
cron = @crontype.new(
:command => "/bin/date > /dev/null",
:minute => [0, 30],
:name => "crontest",
:provider => :crontab
)
}
assert_events([:cron_created], cron)
cron.provider.class.prefetch
cron[:minute] = :absent
assert_events([:minute_changed], cron)
current_values = nil
assert_nothing_raised {
cron.provider.class.prefetch
current_values = cron.retrieve
}
assert_equal(:absent, current_values[cron.property(:minute)])
end
def test_listing
# Make a crontab cron for testing
provider = @crontype.provider(:crontab)
return unless provider.suitable?
ft = provider.filetype
provider.filetype = :ram
cleanup { provider.filetype = ft }
setme
cron = @crontype.new(:name => "testing",
:minute => [0, 30],
:command => "/bin/testing",
:user => @me
)
# Write it to our file
assert_apply(cron)
crons = []
assert_nothing_raised {
@crontype.instances.each do |cron|
crons << cron
end
}
crons.each do |cron|
assert_instance_of(@crontype, cron, "Did not receive a real cron object")
assert_instance_of(String, cron.value(:user),
"Cron user is not a string")
end
end
def verify_failonnouser
assert_raise(Puppet::Error) do
@crontype.retrieve("nosuchuser")
end
end
def test_divisionnumbers
cron = mkcron("divtest")
cron[:minute] = "*/5"
assert_apply(cron)
cron.provider.class.prefetch
currentvalue = cron.retrieve
assert_equal(["*/5"], currentvalue[cron.property(:minute)])
end
def test_ranges
cron = mkcron("rangetest")
cron[:minute] = "2-4"
assert_apply(cron)
current_values = nil
assert_nothing_raised {
cron.provider.class.prefetch
current_values = cron.retrieve
}
assert_equal(["2-4"], current_values[cron.property(:minute)])
end
def provider_set(cron, param, value)
unless param =~ /=$/
param = "%s=" % param
end
cron.provider.send(param, value)
end
def test_value
cron = mkcron("valuetesting", false)
# First, test the normal properties
[:minute, :hour, :month].each do |param|
cron.newattr(param)
property = cron.property(param)
assert(property, "Did not get %s property" % param)
assert_nothing_raised {
# property.is = :absent
provider_set(cron, param, :absent)
}
val = "*"
assert_equal(val, cron.value(param))
# Make sure arrays work, too
provider_set(cron, param, ["1"])
assert_equal(%w{1}, cron.value(param))
# Make sure values get comma-joined
provider_set(cron, param, %w{2 3})
assert_equal(%w{2 3}, cron.value(param))
# Make sure "should" values work, too
cron[param] = "4"
assert_equal(%w{4}, cron.value(param))
cron[param] = ["4"]
assert_equal(%w{4}, cron.value(param))
cron[param] = ["4", "5"]
assert_equal(%w{4 5}, cron.value(param))
provider_set(cron, param, :absent)
assert_equal(%w{4 5}, cron.value(param))
end
Puppet[:trace] = false
# Now make sure that :command works correctly
cron.delete(:command)
cron.newattr(:command)
property = cron.property(:command)
assert_nothing_raised {
provider_set(cron, :command, :absent)
}
param = :command
# Make sure arrays work, too
provider_set(cron, param, ["/bin/echo"])
assert_equal("/bin/echo", cron.value(param))
# Make sure values are not comma-joined
provider_set(cron, param, %w{/bin/echo /bin/test})
assert_equal("/bin/echo", cron.value(param))
# Make sure "should" values work, too
cron[param] = "/bin/echo"
assert_equal("/bin/echo", cron.value(param))
cron[param] = ["/bin/echo"]
assert_equal("/bin/echo", cron.value(param))
cron[param] = %w{/bin/echo /bin/test}
assert_equal("/bin/echo", cron.value(param))
provider_set(cron, param, :absent)
assert_equal("/bin/echo", cron.value(param))
end
def test_multiple_users
crons = []
users = ["root", nonrootuser.name]
users.each do |user|
cron = Puppet::Type.type(:cron).new(
:name => "testcron-#{user}",
:user => user,
:command => "/bin/echo",
:minute => [0,30]
)
crons << cron
assert_equal(cron.should(:user), cron.should(:target),
"Target was not set correctly for %s" % user)
end
provider = crons[0].provider.class
assert_apply(*crons)
users.each do |user|
users.each do |other|
next if user == other
text = provider.target_object(other).read
assert(text !~ /testcron-#{user}/,
"%s's cron job is in %s's tab" %
[user, other])
end
end
end
# Make sure the user stuff defaults correctly.
def test_default_user
crontab = @crontype.provider(:crontab)
if crontab.suitable?
inst = @crontype.new(
:name => "something", :command => "/some/thing",
:provider => :crontab)
assert_equal(Etc.getpwuid(Process.uid).name, inst.should(:user),
"user did not default to current user with crontab")
assert_equal(Etc.getpwuid(Process.uid).name, inst.should(:target),
"target did not default to current user with crontab")
# Now make a new cron with a user, and make sure it gets copied
# over
inst = @crontype.new(:name => "yay", :command => "/some/thing",
:user => "bin", :provider => :crontab)
assert_equal("bin", inst.should(:target),
"target did not default to user with crontab")
end
end
# #705 - make sure extra spaces don't screw things up
def test_spaces_in_command
string = "echo multiple spaces"
cron = @crontype.new(:name => "space testing", :command => string)
assert_apply(cron)
cron = @crontype.new(:name => "space testing", :command => string)
# Now make sure that it's correctly in sync
cron.provider.class.prefetch("testing" => cron)
properties = cron.retrieve
assert_equal(string, properties[:command], "Cron did not pick up extra spaces in command")
assert(cron.parameter(:command).insync?(properties[:command]), "Command changed with multiple spaces")
end
end
|