1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
|
#!/usr/bin/env ruby
$:.unshift("../../lib") if __FILE__ =~ /\.rb$/
require 'puppettest'
class TestMasterClient < Test::Unit::TestCase
include PuppetTest::ServerTest
class FakeTrans
def initialize
@counters = Hash.new { |h,k| h[k] = 0 }
end
[:evaluate, :report, :cleanup, :addtimes, :tags, :ignoreschedules].each do |m|
define_method(m.to_s + "=") do |*args|
@counters[m] += 1
end
define_method(m) do |*args|
@counters[m] += 1
end
define_method(m.to_s + "?") do
@counters[m]
end
end
end
class FakeComponent
attr_accessor :trans
def evaluate
@trans = FakeTrans.new
@trans
end
def finalize
@finalized = true
end
def finalized?
@finalized
end
end
def setup
super
@master = Puppet::Network::Client.master
end
def mkmaster(file = nil)
master = nil
file ||= mktestmanifest()
# create our master
assert_nothing_raised() {
# this is the default server setup
master = Puppet::Network::Handler.master.new(
:Manifest => file,
:UseNodes => false,
:Local => true
)
}
return master
end
def mkclient(master = nil)
master ||= mkmaster()
client = nil
assert_nothing_raised() {
client = Puppet::Network::Client.master.new(
:Master => master
)
}
return client
end
def mk_fake_client
server = Puppet::Network::Handler.master.new :Code => ""
master = Puppet::Network::Client.master.new :Server => server, :Local => true
# Now create some objects
objects = FakeComponent.new
master.send(:instance_variable_set, "@objects", objects)
class << master
def report(r)
@reported ||= 0
@reported += 1
end
def reported
@reported ||= 0
@reported
end
end
return master, objects
end
def test_apply
master, objects = mk_fake_client
check = Proc.new do |hash|
assert(objects.trans, "transaction was not created")
trans = objects.trans
hash[:yes].each do |m|
assert_equal(1, trans.send(m.to_s + "?"), "did not call #{m} enough times")
end
hash[:no].each do |m|
assert_equal(0, trans.send(m.to_s + "?"), "called #{m} too many times")
end
end
# First try it with no arguments
assert_nothing_raised do
master.apply
end
check.call :yes => %w{evaluate cleanup addtimes}, :no => %w{report tags ignoreschedules}
assert_equal(0, master.reported, "master sent report with reports disabled")
# Now enable reporting and make sure the report method gets called
Puppet[:report] = true
assert_nothing_raised do
master.apply
end
check.call :yes => %w{evaluate cleanup addtimes}, :no => %w{tags ignoreschedules}
assert_equal(1, master.reported, "master did not send report")
# Now try it with tags enabled
assert_nothing_raised do
master.apply("tags")
end
check.call :yes => %w{evaluate cleanup tags addtimes}, :no => %w{ignoreschedules}
assert_equal(2, master.reported, "master did not send report")
# and ignoreschedules
assert_nothing_raised do
master.apply("tags", true)
end
check.call :yes => %w{evaluate cleanup tags ignoreschedules addtimes}, :no => %w{}
assert_equal(3, master.reported, "master did not send report")
end
def test_getconfig
client = mkclient
$methodsrun = []
cleanup { $methodsrun = nil }
client.meta_def(:getplugins) do
$methodsrun << :getplugins
end
client.meta_def(:get_actual_config) do
$methodsrun << :get_actual_config
result = Puppet::TransBucket.new()
result.type = "testing"
result.name = "yayness"
result
end
assert_nothing_raised do
client.getconfig
end
[:get_actual_config].each do |method|
assert($methodsrun.include?(method), "method %s was not run" % method)
end
assert(! $methodsrun.include?(:getplugins), "plugins were synced even tho disabled")
# Now set pluginsync
Puppet[:pluginsync] = true
$methodsrun.clear
assert_nothing_raised do
client.getconfig
end
[:getplugins, :get_actual_config].each do |method|
assert($methodsrun.include?(method), "method %s was not run" % method)
end
objects = client.objects
assert(objects.finalized?, "objects were not finalized")
end
def test_disable
FileUtils.mkdir_p(Puppet[:statedir])
manifest = mktestmanifest
master = mkmaster(manifest)
client = mkclient(master)
assert(! FileTest.exists?(@createdfile))
assert_nothing_raised {
client.disable
}
assert_nothing_raised {
client.run
}
assert(! FileTest.exists?(@createdfile), "Disabled client ran")
assert_nothing_raised {
client.enable
}
assert_nothing_raised {
client.run
}
assert(FileTest.exists?(@createdfile), "Enabled client did not run")
end
# Make sure we're getting the client version in our list of facts
def test_clientversionfact
facts = nil
assert_nothing_raised {
facts = Puppet::Network::Client.master.facts
}
assert_equal(Puppet.version.to_s, facts["clientversion"])
end
# Make sure non-string facts don't make things go kablooie
def test_nonstring_facts
FileUtils.mkdir_p(Puppet[:statedir])
# Add a nonstring fact
Facter.add("nonstring") do
setcode { 1 }
end
assert_equal(1, Facter.nonstring, "Fact was a string from facter")
client = mkclient()
assert(! FileTest.exists?(@createdfile))
assert_nothing_raised {
client.run
}
end
# This method is supposed
def test_download
source = tempfile()
dest = tempfile()
sfile = File.join(source, "file")
dfile = File.join(dest, "file")
Dir.mkdir(source)
File.open(sfile, "w") {|f| f.puts "yay"}
files = []
assert_nothing_raised do
files = Puppet::Network::Client.master.download(:dest => dest, :source => source, :name => "testing")
end
assert(FileTest.directory?(dest), "dest dir was not created")
assert(FileTest.file?(dfile), "dest file was not created")
assert_equal(File.read(sfile), File.read(dfile), "Dest file had incorrect contents")
assert_equal([dest, dfile].sort, files.sort, "Changed files were not returned correctly")
end
def test_getplugins
Puppet[:pluginsource] = tempfile()
Dir.mkdir(Puppet[:pluginsource])
myplugin = File.join(Puppet[:pluginsource], "myplugin.rb")
File.open(myplugin, "w") do |f|
f.puts %{Puppet::Type.newtype(:myplugin) do
newparam(:argument) do
isnamevar
end
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getplugins
}
destfile = File.join(Puppet[:plugindest], "myplugin.rb")
assert(File.exists?(destfile), "Did not get plugin")
obj = Puppet::Type.type(:myplugin)
assert(obj, "Did not define type")
assert(obj.validattr?(:argument),
"Did not get namevar")
# Now modify the file and make sure the type is replaced
File.open(myplugin, "w") do |f|
f.puts %{Puppet::Type.newtype(:myplugin) do
newparam(:yayness) do
isnamevar
end
newparam(:rahness) do
end
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getplugins
}
destfile = File.join(Puppet[:pluginpath], "myplugin.rb")
obj = Puppet::Type.type(:myplugin)
assert(obj, "Did not define type")
assert(obj.validattr?(:yayness),
"Did not get namevar")
assert(obj.validattr?(:rahness),
"Did not get other var")
assert(! obj.validattr?(:argument),
"Old namevar is still valid")
# Now try it again, to make sure we don't have any objects lying around
assert_nothing_raised {
Puppet::Network::Client.master.getplugins
}
end
def test_getfacts
Puppet[:factsource] = tempfile()
Dir.mkdir(Puppet[:factsource])
hostname = Facter.value(:hostname)
myfact = File.join(Puppet[:factsource], "myfact.rb")
File.open(myfact, "w") do |f|
f.puts %{Facter.add("myfact") do
setcode { "yayness" }
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
destfile = File.join(Puppet[:factdest], "myfact.rb")
assert(File.exists?(destfile), "Did not get fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
assert_equal("yayness", Facter.value(:myfact),
"Did not get correct fact value")
# Now modify the file and make sure the type is replaced
File.open(myfact, "w") do |f|
f.puts %{Facter.add("myfact") do
setcode { "funtest" }
end
}
end
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
assert_equal("funtest", Facter.value(:myfact),
"Did not reload fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
# Now run it again and make sure the fact still loads
assert_nothing_raised {
Puppet::Network::Client.master.getfacts
}
assert_equal("funtest", Facter.value(:myfact),
"Did not reload fact")
assert_equal(hostname, Facter.value(:hostname),
"Lost value to hostname")
end
# Make sure we load all facts on startup.
def test_loadfacts
dirs = [tempfile(), tempfile()]
count = 0
names = []
dirs.each do |dir|
Dir.mkdir(dir)
name = "fact%s" % count
names << name
file = File.join(dir, "%s.rb" % name)
# Write out a plugin file
File.open(file, "w") do |f|
f.puts %{Facter.add("#{name}") do setcode { "#{name}" } end }
end
count += 1
end
Puppet[:factpath] = dirs.join(":")
names.each do |name|
assert_nil(Facter.value(name), "Somehow retrieved invalid fact")
end
assert_nothing_raised {
Puppet::Network::Client.master.loadfacts
}
names.each do |name|
assert_equal(name, Facter.value(name),
"Did not retrieve facts")
end
end
if Process.uid == 0
# Testing #283. Make sure plugins et al are downloaded as the running user.
def test_download_ownership
dir = tstdir()
dest = tstdir()
file = File.join(dir, "file")
File.open(file, "w") { |f| f.puts "funtest" }
user = nonrootuser()
group = nonrootgroup()
chowner = Puppet::Type.type(:file).create :path => dir,
:owner => user.name, :group => group.name, :recurse => true
assert_apply(chowner)
chowner.remove
assert_equal(user.uid, File.stat(file).uid)
assert_equal(group.gid, File.stat(file).gid)
assert_nothing_raised {
Puppet::Network::Client.master.download(:dest => dest, :source => dir,
:name => "testing"
) {}
}
destfile = File.join(dest, "file")
assert(FileTest.exists?(destfile), "Did not create destfile")
assert_equal(Process.uid, File.stat(destfile).uid)
end
end
# Test retrieving all of the facts.
def test_facts
facts = nil
assert_nothing_raised do
facts = Puppet::Network::Client.master.facts
end
Facter.to_hash.each do |fact, value|
assert_equal(facts[fact.downcase], value, "%s is not equal" % fact.inspect)
end
# Make sure the puppet version got added
assert_equal(Puppet::PUPPETVERSION, facts["clientversion"], "client version did not get added")
# And make sure the ruby version is in there
assert_equal(RUBY_VERSION, facts["rubyversion"], "ruby version did not get added")
end
# #424
def test_caching_of_compile_time
file = tempfile()
manifest = tempfile()
File.open(manifest, "w") { |f| f.puts "file { '#{file}': content => yay }" }
driver = mkmaster(manifest)
driver.local = false
master = mkclient(driver)
# We have to make everything thinks it's remote, because there's no local caching info
master.local = false
assert(! master.fresh?(master.class.facts),
"Considered fresh with no compile at all")
assert_nothing_raised { master.run }
assert(master.fresh?(master.class.facts),
"not considered fresh after compile")
# Now make sure the config time is cached
assert(master.compile_time, "No stored config time")
assert_equal(master.compile_time, Puppet::Util::Storage.cache(:configuration)[:compile_time], "times did not match")
time = master.compile_time
master.clear
File.unlink(file)
Puppet::Util::Storage.store
# Now make a new master
Puppet::Util::Storage.clear
master = mkclient(driver)
master.run
assert_equal(time, master.compile_time, "time was not retrieved from cache")
assert(FileTest.exists?(file), "file was not created on second run")
end
def test_default_objects
# Make sure they start out missing
assert_nil(Puppet::Type.type(:filebucket)["puppet"],
"default filebucket already exists")
assert_nil(Puppet::Type.type(:schedule)["daily"],
"default schedules already exists")
master = mkclient()
# Now make sure they got created
assert(Puppet::Type.type(:filebucket)["puppet"],
"default filebucket not found")
assert(Puppet::Type.type(:schedule)["daily"],
"default schedules not found")
# clear everything, and make sure we can recreate them
Puppet::Type.allclear
assert_nil(Puppet::Type.type(:filebucket)["puppet"],
"default filebucket not removed")
assert_nil(Puppet::Type.type(:schedule)["daily"],
"default schedules not removed")
assert_nothing_raised { master.mkdefault_objects }
assert(Puppet::Type.type(:filebucket)["puppet"],
"default filebucket not found")
assert(Puppet::Type.type(:schedule)["daily"],
"default schedules not found")
# Make sure we've got schedules
assert(Puppet::Type.type(:schedule)["hourly"], "Could not retrieve hourly schedule")
assert(Puppet::Type.type(:filebucket)["puppet"], "Could not retrieve default bucket")
end
# #540 - make sure downloads aren't affected by noop
def test_download_in_noop
source = tempfile
File.open(source, "w") { |f| f.puts "something" }
dest = tempfile
Puppet[:noop] = true
assert_nothing_raised("Could not download in noop") do
@master.download(:dest => dest, :source => source, :tag => "yay")
end
assert(FileTest.exists?(dest), "did not download in noop mode")
assert(Puppet[:noop], "noop got disabled in run")
end
# #491 - make sure a missing config doesn't kill us
def test_missing_localconfig
master = mkclient
master.local = false
driver = master.send(:instance_variable_get, "@driver")
driver.local = false
# Retrieve the configuration
master.getconfig
# Now the config is up to date, so get rid of the @objects var and
# the cached config
master.clear
File.unlink(master.cachefile)
assert_nothing_raised("Missing cache file threw error") do
master.getconfig
end
assert(! @logs.detect { |l| l.message =~ /Could not load/},
"Tried to load cache when it is non-existent")
end
# #519 - cache the facts so that we notice if they change.
def test_factchanges_cause_recompile
$value = "one"
Facter.add(:testfact) do
setcode { $value }
end
assert_equal("one", Facter.value(:testfact), "fact was not set correctly")
master = mkclient
master.local = false
driver = master.send(:instance_variable_get, "@driver")
driver.local = false
assert_nothing_raised("Could not compile config") do
master.getconfig
end
$value = "two"
Facter.clear
Facter.loadfacts
Facter.add(:testfact) do
setcode { $value }
end
facts = master.class.facts
assert_equal("two", Facter.value(:testfact), "fact did not change")
assert(master.send(:facts_changed?, facts),
"master does not think facts changed")
assert(! master.fresh?(facts),
"master is considered fresh after facts changed")
assert_nothing_raised("Could not recompile when facts changed") do
master.getconfig
end
end
def test_locking
master = mkclient
class << master
def getconfig
raise ArgumentError, "Just testing"
end
end
assert_raise(ArgumentError, "did not fail") do
master.run
end
assert(! master.send(:lockfile).locked?,
"Master is still locked after failure")
end
end
# $Id$
|