1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
|
#!/usr/bin/env ruby
require File.dirname(__FILE__) + '/../lib/puppettest'
require 'puppettest'
require 'mocha'
require 'puppet/network/authstore'
class TestAuthStore < Test::Unit::TestCase
include PuppetTest
Declaration = Puppet::Network::AuthStore::Declaration
def mkstore
store = nil
assert_nothing_raised {
store = Puppet::Network::AuthStore.new
}
return store
end
def setup
super
@store = mkstore
end
def test_localallow
Puppet[:trace] = false
assert_nothing_raised {
assert(@store.allowed?(nil, nil), "Store disallowed local access")
}
assert_raise(Puppet::DevError) {
@store.allowed?("kirby.madstop.com", nil)
}
assert_raise(Puppet::DevError) {
@store.allowed?(nil, "192.168.0.1")
}
end
def test_simpleips
%w{
192.168.0.5
7.0.48.7
}.each { |ip|
assert_nothing_raised("Failed to @store IP address %s" % ip) {
@store.allow(ip)
}
assert(@store.allowed?("hosttest.com", ip), "IP %s not allowed" % ip)
}
#assert_raise(Puppet::AuthStoreError) {
# @store.allow("192.168.674.0")
#}
assert_raise(Puppet::AuthStoreError) {
@store.allow("192.168.0")
}
end
def test_ipranges
%w{
192.168.0.*
192.168.1.0/24
192.178.*
193.179.0.0/8
}.each { |range|
assert_nothing_raised("Failed to @store IP range %s" % range) {
@store.allow(range)
}
}
%w{
192.168.0.1
192.168.1.5
192.178.0.5
193.0.0.1
}.each { |ip|
assert(@store.allowed?("fakename.com", ip), "IP %s is not allowed" % ip)
}
end
def test_iprangedenials
assert_nothing_raised("Failed to @store overlapping IP ranges") {
@store.allow("192.168.0.0/16")
@store.deny("192.168.0.0/24")
}
assert(@store.allowed?("fake.name", "192.168.1.50"), "/16 ip not allowed")
assert(! @store.allowed?("fake.name", "192.168.0.50"), "/24 ip allowed")
end
def test_subdomaindenails
assert_nothing_raised("Failed to @store overlapping IP ranges") {
@store.allow("*.madstop.com")
@store.deny("*.sub.madstop.com")
}
assert(@store.allowed?("hostname.madstop.com", "192.168.1.50"),
"hostname not allowed")
assert(! @store.allowed?("name.sub.madstop.com", "192.168.0.50"),
"subname name allowed")
end
def test_orderingstuff
assert_nothing_raised("Failed to @store overlapping IP ranges") {
@store.allow("*.madstop.com")
@store.deny("192.168.0.0/24")
}
assert(@store.allowed?("hostname.madstop.com", "192.168.1.50"),
"hostname not allowed")
assert(! @store.allowed?("hostname.madstop.com", "192.168.0.50"),
"Host allowed over IP")
end
def test_globalallow
assert_nothing_raised("Failed to add global allow") {
@store.allow("*")
}
[
%w{hostname.com 192.168.0.4},
%w{localhost 192.168.0.1},
%w{localhost 127.0.0.1}
].each { |ary|
assert(@store.allowed?(*ary), "Failed to allow %s" % [ary.join(",")])
}
end
def test_store
assert_nothing_raised do
assert_nil(@store.send(:store, :allow, "*.host.com"),
"store did not return nil")
end
assert_equal([Declaration.new(:allow, "*.host.com")],
@store.send(:instance_variable_get, "@declarations"),
"Did not store declaration")
# Now add another one and make sure it gets sorted appropriately
assert_nothing_raised do
assert_nil(@store.send(:store, :allow, "me.host.com"),
"store did not return nil")
end
assert_equal([
Declaration.new(:allow, "me.host.com"),
Declaration.new(:allow, "*.host.com")
],
@store.send(:instance_variable_get, "@declarations"),
"Did not sort declarations")
end
def test_allow_and_deny
store = Puppet::Network::AuthStore.new
store.expects(:store).with(:allow, "host.com")
store.allow("host.com")
store = Puppet::Network::AuthStore.new
store.expects(:store).with(:deny, "host.com")
store.deny("host.com")
store = Puppet::Network::AuthStore.new
assert_nothing_raised do
assert_nil(store.allow("*"),
"allow did not return nil")
end
assert(store.globalallow?,
"did not enable global allow")
end
def test_hostnames
Puppet[:trace] = false
%w{
kirby.madstop.com
luke.madstop.net
name-other.madstop.net
}.each { |name|
assert_nothing_raised("Failed to @store simple name %s" % name) {
@store.allow(name)
}
assert(@store.allowed?(name, "192.168.0.1"), "Name %s not allowed" % name)
}
%w{
invalid
^invalid!
inval$id
}.each { |pat|
assert_raise(Puppet::AuthStoreError,
"name '%s' was allowed" % pat) {
@store.allow(pat)
}
}
end
def test_domains
assert_nothing_raised("Failed to @store domains") {
@store.allow("*.a.very.long.domain.name.com")
@store.allow("*.madstop.com")
@store.allow("*.some-other.net")
@store.allow("*.much.longer.more-other.net")
}
%w{
madstop.com
culain.madstop.com
kirby.madstop.com
funtest.some-other.net
ya-test.madstop.com
some.much.much.longer.more-other.net
}.each { |name|
assert(@store.allowed?(name, "192.168.0.1"), "Host %s not allowed" % name)
}
assert_raise(Puppet::AuthStoreError) {
@store.allow("domain.*.com")
}
assert(!@store.allowed?("very.long.domain.name.com", "1.2.3.4"),
"Long hostname allowed")
assert_raise(Puppet::AuthStoreError) {
@store.allow("domain.*.other.com")
}
end
# #531
def test_case_insensitivity
@store.allow("hostname.com")
%w{hostname.com Hostname.COM hostname.Com HOSTNAME.COM}.each do |name|
assert(@store.allowed?(name, "127.0.0.1"),
"did not allow %s" % name)
end
end
def test_allowed?
Puppet[:trace] = false
assert(@store.allowed?(nil, nil),
"Did not default to true for local checks")
assert_raise(Puppet::DevError, "did not fail on one input") do
@store.allowed?("host.com", nil)
end
assert_raise(Puppet::DevError, "did not fail on one input") do
@store.allowed?(nil, "192.168.0.1")
end
end
# Make sure more specific allows and denies win over generalities
def test_specific_overrides
@store.allow("host.madstop.com")
@store.deny("*.madstop.com")
assert(@store.allowed?("host.madstop.com", "192.168.0.1"),
"More specific allowal by name failed")
@store.allow("192.168.0.1")
@store.deny("192.168.0.0/24")
assert(@store.allowed?("host.madstop.com", "192.168.0.1"),
"More specific allowal by ip failed")
end
def test_dynamic_backreferences
@store.allow("$1.madstop.com")
assert_nothing_raised { @store.interpolate([nil, "host"]) }
assert(@store.allowed?("host.madstop.com", "192.168.0.1"), "interpolation failed")
assert_nothing_raised { @store.reset_interpolation }
end
def test_dynamic_ip
@store.allow("192.168.0.$1")
assert_nothing_raised { @store.interpolate([nil, "12"]) }
assert(@store.allowed?("host.madstop.com", "192.168.0.12"), "interpolation failed")
assert_nothing_raised { @store.reset_interpolation }
end
def test_multiple_dynamic_backreferences
@store.allow("$1.$2")
assert_nothing_raised { @store.interpolate([nil, "host", "madstop.com"]) }
assert(@store.allowed?("host.madstop.com", "192.168.0.1"), "interpolation failed")
assert_nothing_raised { @store.reset_interpolation }
end
def test_multithreaded_allow_with_dynamic_backreferences
@store.allow("$1.madstop.com")
threads = []
9.times { |a|
threads << Thread.new {
9.times { |b|
Thread.pass
@store.interpolate([nil, "a#{b}", "madstop.com"])
Thread.pass
assert( @store.allowed?("a#{b}.madstop.com", "192.168.0.1") )
Thread.pass
@store.reset_interpolation
Thread.pass
}
}
}
threads.each { |th| th.join }
end
end
class TestAuthStoreDeclaration < PuppetTest::TestCase
include PuppetTest
Declaration = Puppet::Network::AuthStore::Declaration
def setup
super
@decl = Declaration.new(:allow, "hostname.com")
end
def test_parse
{
"192.168.0.1" => [:ip, IPAddr.new("192.168.0.1"), nil],
"2001:700:300:1800::" => [:ip, IPAddr.new("2001:700:300:1800::"), nil],
"2001:700:300:1800::/64" => [:ip, IPAddr.new("2001:700:300:1800::/64"), 64],
"192.168.0.1/32" => [:ip, IPAddr.new("192.168.0.1/32"), 32],
"192.168.0.1/24" => [:ip, IPAddr.new("192.168.0.1/24"), 24],
"192.*" => [:ip, IPAddr.new("192.0.0.0/8"), 8],
"192.168.*" => [:ip, IPAddr.new("192.168.0.0/16"), 16],
"192.168.0.*" => [:ip, IPAddr.new("192.168.0.0/24"), 24],
"hostname.com" => [:domain, %w{com hostname}, nil],
"Hostname.COM" => [:domain, %w{com hostname}, nil],
"billy.Hostname.COM" => [:domain, %w{com hostname billy}, nil],
"billy-jean.Hostname.COM" => [:domain, %w{com hostname billy-jean}, nil],
"*.hostname.COM" => [:domain, %w{com hostname}, 2],
"*.hostname.COM" => [:domain, %w{com hostname}, 2],
"$1.hostname.COM" => [:dynamic, %w{com hostname $1}, nil],
"192.168.$1.$2" => [:dynamic, %w{$2 $1 168 192}, nil]
}.each do |input, output|
# Create a new decl each time, so values aren't cached.
assert_nothing_raised do
@decl = Declaration.new(:allow, input)
end
[:name, :pattern, :length].zip(output).each do |method, value|
assert_equal(value, @decl.send(method),
"Got incorrect value for %s from %s" % [method, input])
end
end
%w{192.168 hostname -hostname.com hostname.*}.each do |input|
assert_raise(Puppet::AuthStoreError, "Did not fail on %s" % input) do
@decl.pattern = input
end
end
["hostname .com", "192.168 .0.1"].each do |input|
assert_raise(Puppet::AuthStoreError, "Did not fail on %s" % input) do
@decl.pattern = input
end
end
end
def test_result
["allow", :allow].each do |val|
assert_nothing_raised { @decl.type = val }
assert_equal(true, @decl.result, "did not result to true with %s" %
val.inspect)
end
[:deny, "deny"].each do |val|
assert_nothing_raised { @decl.type = val }
assert_equal(false, @decl.result,
"did not result to false with %s" % val.inspect)
end
["yay", 1, nil, false, true].each do |val|
assert_raise(ArgumentError, "Did not fail on %s" % val.inspect) do
@decl.type = val
end
end
end
def test_munge_name
{
"hostname.com" => %w{com hostname},
"alley.hostname.com" => %w{com hostname alley},
"*.hostname.com" => %w{com hostname *},
"*.HOSTNAME.Com" => %w{com hostname *},
"*.HOSTNAME.Com" => %w{com hostname *},
}.each do |input, output|
assert_equal(output, @decl.send(:munge_name, input),
"munged %s incorrectly" % input)
end
end
# Make sure people can specify TLDs
def test_match_tlds
assert_nothing_raised {
@decl.pattern = "*.tld"
}
assert_equal(%w{tld}, @decl.pattern, "Failed to allow custom tld")
end
# Make sure we sort correctly.
def test_sorting
# Make sure declarations with no length sort first.
host_exact = Declaration.new(:allow, "host.com")
host_range = Declaration.new(:allow, "*.host.com")
ip_exact = Declaration.new(:allow, "192.168.0.1")
ip_range = Declaration.new(:allow, "192.168.0.*")
assert_equal(-1, host_exact <=> host_range,
"exact name match did not sort first")
assert_equal(-1, ip_exact <=> ip_range,
"exact ip match did not sort first")
# Next make sure we sort by length
ip_long = Declaration.new(:allow, "192.168.*")
assert_equal(-1, ip_range <=> ip_long, "/16 sorted before /24 in ip")
# Now try it using masks
ip24 = Declaration.new(:allow, "192.168.0.0/24")
ip16 = Declaration.new(:allow, "192.168.0.0/16")
assert_equal(-1, ip24 <=> ip16, "/16 sorted before /24 in ip with masks")
# Make sure ip checks sort before host checks
assert_equal(-1, ip_exact <=> host_exact,
"IP exact did not sort before host exact")
assert_equal(-1, ip_range <=> host_range,
"IP range did not sort before host range")
host_long = Declaration.new(:allow, "*.domain.host.com")
assert_equal(-1, host_long <=> host_range, "did not sort by domain length")
# Now make sure denies sort before allows, for equivalent
# declarations.
host_deny = Declaration.new(:deny, "host.com")
assert_equal(-1, host_deny <=> host_exact, "deny did not sort before allow when exact")
host_range_deny = Declaration.new(:deny, "*.host.com")
assert_equal(-1, host_range_deny <=> host_range,
"deny did not sort before allow when ranged")
ip_allow = Declaration.new(:allow, "192.168.0.0/16")
ip_deny = Declaration.new(:deny, "192.168.0.0/16")
assert_equal(-1, ip_deny <=> ip_allow,
"deny did not sort before allow in ip range")
%w{host.com *.domain.com 192.168.0.1 192.168.0.1/24}.each do |decl|
assert_equal(0, Declaration.new(:allow, decl) <=>
Declaration.new(:allow, decl),
"Equivalent declarations for %s were considered different" %
decl
)
end
end
def test_match?
host = Declaration.new(:allow, "host.com")
host.expects(:matchname?).with("host.com")
host.match?("host.com", "192.168.0.1")
ip = Declaration.new(:allow, "192.168.0.1")
ip.pattern.expects(:include?)
ip.match?("host.com", "192.168.0.1")
end
def test_matchname?
host = Declaration.new(:allow, "host.com")
assert(host.send(:matchname?, "host.com"), "exact did not match")
assert(! host.send(:matchname?, "yay.com"), "incorrect match")
domain = Declaration.new(:allow, "*.domain.com")
%w{host.domain.com domain.com very.long.domain.com very-long.domain.com
}.each do |name|
assert(domain.send(:matchname?, name),
"Did not match %s" % name)
end
end
end
|