summaryrefslogtreecommitdiffstats
path: root/spec/unit/interface/action_spec.rb
blob: 4be6a1c55529b061f2f1dd92272bc20ea267442b (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
#!/usr/bin/env rspec
require 'spec_helper'
require 'puppet/interface/action'

describe Puppet::Interface::Action do
  describe "when validating the action name" do
    [nil, '', 'foo bar', '-foobar'].each do |input|
      it "should treat #{input.inspect} as an invalid name" do
        expect { Puppet::Interface::Action.new(nil, input) }.
          should raise_error(/is an invalid action name/)
      end
    end
  end

  describe "when invoking" do
    it "should be able to call other actions on the same object" do
      face = Puppet::Interface.new(:my_face, '0.0.1') do
        action(:foo) do
          when_invoked { 25 }
        end

        action(:bar) do
          when_invoked { "the value of foo is '#{foo}'" }
        end
      end
      face.foo.should == 25
      face.bar.should == "the value of foo is '25'"
    end

    # bar is a class action calling a class action
    # quux is a class action calling an instance action
    # baz is an instance action calling a class action
    # qux is an instance action calling an instance action
    it "should be able to call other actions on the same object when defined on a class" do
      class Puppet::Interface::MyInterfaceBaseClass < Puppet::Interface
        action(:foo) do
          when_invoked { 25 }
        end

        action(:bar) do
          when_invoked { "the value of foo is '#{foo}'" }
        end

        action(:quux) do
          when_invoked { "qux told me #{qux}" }
        end
      end

      face = Puppet::Interface::MyInterfaceBaseClass.new(:my_inherited_face, '0.0.1') do
        action(:baz) do
          when_invoked { "the value of foo in baz is '#{foo}'" }
        end

        action(:qux) do
          when_invoked { baz }
        end
      end
      face.foo.should  == 25
      face.bar.should  == "the value of foo is '25'"
      face.quux.should == "qux told me the value of foo in baz is '25'"
      face.baz.should  == "the value of foo in baz is '25'"
      face.qux.should  == "the value of foo in baz is '25'"
    end

    context "when calling the Ruby API" do
      let :face do
        Puppet::Interface.new(:ruby_api, '1.0.0') do
          action :bar do
            when_invoked do |options|
              options
            end
          end
        end
      end

      it "should work when no options are supplied" do
        options = face.bar
        options.should == {}
      end

      it "should work when options are supplied" do
        options = face.bar(:bar => "beer")
        options.should == { :bar => "beer" }
      end
    end
  end

  describe "with action-level options" do
    it "should support options with an empty block" do
      face = Puppet::Interface.new(:action_level_options, '0.0.1') do
        action :foo do
          option "--bar" do
            # this line left deliberately blank
          end
        end
      end

      face.should_not be_option :bar
      face.get_action(:foo).should be_option :bar
    end

    it "should return only action level options when there are no face options" do
      face = Puppet::Interface.new(:action_level_options, '0.0.1') do
        action :foo do option "--bar" end
      end

      face.get_action(:foo).options.should =~ [:bar]
    end

    describe "with both face and action options" do
      let :face do
        Puppet::Interface.new(:action_level_options, '0.0.1') do
          action :foo do option "--bar" end
          action :baz do option "--bim" end
          option "--quux"
        end
      end

      it "should return combined face and action options" do
        face.get_action(:foo).options.should =~ [:bar, :quux]
      end

      it "should fetch options that the face inherited" do
        parent = Class.new(Puppet::Interface)
        parent.option "--foo"
        child = parent.new(:inherited_options, '0.0.1') do
          option "--bar"
          action :action do option "--baz" end
        end

        action = child.get_action(:action)
        action.should be

        [:baz, :bar, :foo].each do |name|
          action.get_option(name).should be_an_instance_of Puppet::Interface::Option
        end
      end

      it "should get an action option when asked" do
        face.get_action(:foo).get_option(:bar).
          should be_an_instance_of Puppet::Interface::Option
      end

      it "should get a face option when asked" do
        face.get_action(:foo).get_option(:quux).
          should be_an_instance_of Puppet::Interface::Option
      end

      it "should return options only for this action" do
        face.get_action(:baz).options.should =~ [:bim, :quux]
      end
    end

    it_should_behave_like "things that declare options" do
      def add_options_to(&block)
        face = Puppet::Interface.new(:with_options, '0.0.1') do
          action(:foo, &block)
        end
        face.get_action(:foo)
      end
    end

    it "should fail when a face option duplicates an action option" do
      expect {
        Puppet::Interface.new(:action_level_options, '0.0.1') do
          option "--foo"
          action :bar do option "--foo" end
        end
      }.should raise_error ArgumentError, /Option foo conflicts with existing option foo/i
    end
  end

  context "with action decorators" do
    context "local only" do
      let :face do
        Puppet::Interface.new(:action_decorators, '0.0.1') do
          action :bar do when_invoked do true end end
          def report(arg) end
        end
      end

      it "should call action before decorators" do
        face.action(:baz) do
          option "--baz" do
            before_action do |action, args, options|
              report(:action_option)
            end
          end
          when_invoked do true end
        end

        face.expects(:report).with(:action_option)
        face.baz :baz => true
      end

      it "should call action after decorators" do
        face.action(:baz) do
          option "--baz" do
            after_action do |action, args, options|
              report(:action_option)
            end
          end
          when_invoked do true end
        end

        face.expects(:report).with(:action_option)
        face.baz :baz => true
      end

      it "should call local before decorators" do
        face.option "--foo FOO" do
          before_action do |action, args, options|
            report(:before)
          end
        end
        face.expects(:report).with(:before)
        face.bar({:foo => 12})
      end

      it "should call local after decorators" do
        face.option "--foo FOO" do
          after_action do |action, args, options| report(:after) end
        end
        face.expects(:report).with(:after)
        face.bar({:foo => 12})
      end

      context "with inactive decorators" do
        it "should not invoke a decorator if the options are empty" do
          face.option "--foo FOO" do
            before_action do |action, args, options|
              report :before_action
            end
          end
          face.expects(:report).never # I am testing the negative.
          face.bar
        end

        context "with some decorators only" do
          before :each do
            face.option "--foo" do
              before_action do |action, args, options| report :foo end
            end
            face.option "--bar" do
              before_action do |action, args, options| report :bar end
            end
          end

          it "should work with the foo option" do
            face.expects(:report).with(:foo)
            face.bar(:foo => true)
          end

          it "should work with the bar option" do
            face.expects(:report).with(:bar)
            face.bar(:bar => true)
          end

          it "should work with both options" do
            face.expects(:report).with(:foo)
            face.expects(:report).with(:bar)
            face.bar(:foo => true, :bar => true)
          end
        end
      end
    end

    context "with inherited decorators" do
      let :parent do
        parent = Class.new(Puppet::Interface)
        parent.script :on_parent do :on_parent end
        parent.define_method :report do |arg| arg end
        parent
      end

      let :child do
        child = parent.new(:inherited_decorators, '0.0.1') do
          script :on_child do :on_child end
        end
      end

      context "with a child decorator" do
        subject do
          child.option "--foo FOO" do
            before_action do |action, args, options|
              report(:child_before)
            end
          end
          child.expects(:report).with(:child_before)
          child
        end

        it "child actions should invoke the decorator" do
          subject.on_child({:foo => true, :bar => true}).should == :on_child
        end

        it "parent actions should invoke the decorator" do
          subject.on_parent({:foo => true, :bar => true}).should == :on_parent
        end
      end

      context "with a parent decorator" do
        subject do
          parent.option "--foo FOO" do
            before_action do |action, args, options|
              report(:parent_before)
            end
          end
          child.expects(:report).with(:parent_before)
          child
        end

        it "child actions should invoke the decorator" do
          subject.on_child({:foo => true, :bar => true}).should == :on_child
        end

        it "parent actions should invoke the decorator" do
          subject.on_parent({:foo => true, :bar => true}).should == :on_parent
        end
      end

      context "with child and parent decorators" do
        subject do
          parent.option "--foo FOO" do
            before_action { |action, args, options| report(:parent_before) }
            after_action  { |action, args, options| report(:parent_after)  }
          end
          child.option "--bar BAR" do
            before_action { |action, args, options| report(:child_before) }
            after_action  { |action, args, options| report(:child_after)  }
          end

          child.expects(:report).with(:child_before)
          child.expects(:report).with(:parent_before)
          child.expects(:report).with(:parent_after)
          child.expects(:report).with(:child_after)

          child
        end

        it "child actions should invoke all the decorator" do
          subject.on_child({:foo => true, :bar => true}).should == :on_child
        end

        it "parent actions should invoke all the decorator" do
          subject.on_parent({:foo => true, :bar => true}).should == :on_parent
        end
      end
    end
  end
end