summaryrefslogtreecommitdiffstats
path: root/spec/unit/application/apply_spec.rb
blob: 66c658e7fda948b9c4aa9cb0d591d92a7c0b2216 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
#!/usr/bin/env rspec
require 'spec_helper'

require 'puppet/application/apply'
require 'puppet/file_bucket/dipper'
require 'puppet/configurer'

describe Puppet::Application::Apply do
  before :each do
    @apply = Puppet::Application[:apply]
    Puppet::Util::Log.stubs(:newdestination)
    Puppet::Util::Log.stubs(:level=)
  end

  [:debug,:loadclasses,:verbose,:use_nodes,:detailed_exitcodes].each do |option|
    it "should declare handle_#{option} method" do
      @apply.should respond_to("handle_#{option}".to_sym)
    end

    it "should store argument value when calling handle_#{option}" do
      @apply.options.expects(:[]=).with(option, 'arg')
      @apply.send("handle_#{option}".to_sym, 'arg')
    end
  end

  it "should set the code to the provided code when :execute is used" do
    @apply.options.expects(:[]=).with(:code, 'arg')
    @apply.send("handle_execute".to_sym, 'arg')
  end

  it "should ask Puppet::Application to parse Puppet configuration file" do
    @apply.should_parse_config?.should be_true
  end

  describe "when applying options" do

    it "should set the log destination with --logdest" do
      Puppet::Log.expects(:newdestination).with("console")

      @apply.handle_logdest("console")
    end

    it "should put the logset options to true" do
      @apply.options.expects(:[]=).with(:logset,true)

      @apply.handle_logdest("console")
    end
  end

  describe "during setup" do

    before :each do
      Puppet::Log.stubs(:newdestination)
      Puppet::Log.stubs(:level=)
      Puppet.stubs(:parse_config)
      Puppet::FileBucket::Dipper.stubs(:new)
      STDIN.stubs(:read)
      Puppet::Transaction::Report.indirection.stubs(:cache_class=)

      @apply.options.stubs(:[]).with(any_parameters)
    end

    it "should set show_diff on --noop" do
      Puppet.stubs(:[]=)
      Puppet.stubs(:[]).with(:config)
      Puppet.stubs(:[]).with(:noop).returns(true)

      Puppet.expects(:[]=).with(:show_diff, true)

      @apply.setup
    end

    it "should set console as the log destination if logdest option wasn't provided" do
      Puppet::Log.expects(:newdestination).with(:console)

      @apply.setup
    end

    it "should set INT trap" do
      Signal.expects(:trap).with(:INT)

      @apply.setup
    end

    it "should set log level to debug if --debug was passed" do
      @apply.options.stubs(:[]).with(:debug).returns(true)

      Puppet::Log.expects(:level=).with(:debug)

      @apply.setup
    end

    it "should set log level to info if --verbose was passed" do
      @apply.options.stubs(:[]).with(:verbose).returns(true)

      Puppet::Log.expects(:level=).with(:info)

      @apply.setup
    end

    it "should print puppet config if asked to in Puppet config" do
      @apply.stubs(:exit)
      Puppet.settings.stubs(:print_configs?).returns(true)

      Puppet.settings.expects(:print_configs)

      @apply.setup
    end

    it "should exit after printing puppet config if asked to in Puppet config" do
      Puppet.settings.stubs(:print_configs?).returns(true)

      lambda { @apply.setup }.should raise_error(SystemExit)
    end

    it "should tell the report handler to cache locally as yaml" do
      Puppet::Transaction::Report.indirection.expects(:cache_class=).with(:yaml)

      @apply.setup
    end
  end

  describe "when executing" do

    it "should dispatch to parseonly if parseonly is set" do
      @apply.stubs(:options).returns({})
      Puppet.stubs(:[]).with(:parseonly).returns(true)

      @apply.expects(:parseonly)
      @apply.run_command
    end

    it "should dispatch to 'apply' if it was called with 'apply'" do
      @apply.options[:catalog] = "foo"

      @apply.expects(:apply)
      @apply.run_command
    end

    it "should dispatch to main if parseonly is not set" do
      @apply.stubs(:options).returns({})
      Puppet.stubs(:[]).with(:parseonly).returns(false)

      @apply.expects(:main)
      @apply.run_command
    end

    describe "the parseonly command" do
      before :each do
        @environment = Puppet::Node::Environment.new("env")
        Puppet.stubs(:[]).with(:environment).returns(@environment)
        Puppet.stubs(:[]).with(:manifest).returns("site.pp")
        Puppet.stubs(:err)
        @apply.stubs(:exit)
        @apply.options.stubs(:[]).with(:code).returns "some code"
      end

      it "should use the environment to parse the file" do
        @environment.stubs(:perform_initial_import)
        @apply.parseonly
      end

      it "should exit with exit code 0 if no error" do
        @apply.expects(:exit).with(0)
        @apply.parseonly
      end

      it "should exit with exit code 1 if error" do
        @environment.stubs(:perform_initial_import).raises(Puppet::ParseError)
        @apply.expects(:exit).with(1)
        @apply.parseonly
      end

      it "should exit with exit code 1 if error, even if --noop is set" do
        Puppet[:noop] = true
        @environment.stubs(:perform_initial_import).raises(Puppet::ParseError)
        @apply.expects(:exit).with(1)
        @apply.parseonly
      end
    end

    describe "the main command" do
      before :each do
        Puppet.stubs(:[])
        Puppet.settings.stubs(:use)
        Puppet.stubs(:[]).with(:prerun_command).returns ""
        Puppet.stubs(:[]).with(:postrun_command).returns ""
        Puppet.stubs(:[]).with(:trace).returns(true)

        @apply.options.stubs(:[])

        @facts = stub_everything 'facts'
        Puppet::Node::Facts.indirection.stubs(:find).returns(@facts)

        @node = stub_everything 'node'
        Puppet::Node.indirection.stubs(:find).returns(@node)

        @catalog = stub_everything 'catalog'
        @catalog.stubs(:to_ral).returns(@catalog)
        Puppet::Resource::Catalog.indirection.stubs(:find).returns(@catalog)

        STDIN.stubs(:read)

        @transaction = stub_everything 'transaction'
        @catalog.stubs(:apply).returns(@transaction)

        @apply.stubs(:exit)

        Puppet::Util::Storage.stubs(:load)
        Puppet::Configurer.any_instance.stubs(:save_last_run_summary) # to prevent it from trying to write files
      end

      it "should set the code to run from --code" do
        @apply.options.stubs(:[]).with(:code).returns("code to run")
        Puppet.expects(:[]=).with(:code,"code to run")

        @apply.main
      end

      it "should set the code to run from STDIN if no arguments" do
        @apply.command_line.stubs(:args).returns([])
        STDIN.stubs(:read).returns("code to run")

        Puppet.expects(:[]=).with(:code,"code to run")

        @apply.main
      end

      it "should set the manifest if a file is passed on command line and the file exists" do
        File.stubs(:exist?).with('site.pp').returns true
        @apply.command_line.stubs(:args).returns(['site.pp'])

        Puppet.expects(:[]=).with(:manifest,"site.pp")

        @apply.main
      end

      it "should raise an error if a file is passed on command line and the file does not exist" do
        File.stubs(:exist?).with('noexist.pp').returns false
        @apply.command_line.stubs(:args).returns(['noexist.pp'])
        lambda { @apply.main }.should raise_error(RuntimeError, 'Could not find file noexist.pp')
      end

      it "should set the manifest to the first file and warn other files will be skipped" do
        File.stubs(:exist?).with('starwarsIV').returns true
        File.expects(:exist?).with('starwarsI').never
        @apply.command_line.stubs(:args).returns(['starwarsIV', 'starwarsI', 'starwarsII'])

        Puppet.expects(:[]=).with(:manifest,"starwarsIV")
        Puppet.expects(:warning).with('Only one file can be applied per run.  Skipping starwarsI, starwarsII')

        @apply.main
      end

      it "should collect the node facts" do
        Puppet::Node::Facts.indirection.expects(:find).returns(@facts)

        @apply.main
      end

      it "should raise an error if we can't find the node" do
        Puppet::Node::Facts.indirection.expects(:find).returns(nil)

        lambda { @apply.main }.should raise_error
      end

      it "should look for the node" do
        Puppet::Node.indirection.expects(:find).returns(@node)

        @apply.main
      end

      it "should raise an error if we can't find the node" do
        Puppet::Node.indirection.expects(:find).returns(nil)

        lambda { @apply.main }.should raise_error
      end

      it "should merge in our node the loaded facts" do
        @facts.stubs(:values).returns("values")

        @node.expects(:merge).with("values")

        @apply.main
      end

      it "should load custom classes if loadclasses" do
        @apply.options.stubs(:[]).with(:loadclasses).returns(true)
        Puppet.stubs(:[]).with(:classfile).returns("/etc/puppet/classes.txt")
        FileTest.stubs(:exists?).with("/etc/puppet/classes.txt").returns(true)
        FileTest.stubs(:readable?).with("/etc/puppet/classes.txt").returns(true)
        File.stubs(:read).with("/etc/puppet/classes.txt").returns("class")

        @node.expects(:classes=)

        @apply.main
      end

      it "should compile the catalog" do
        Puppet::Resource::Catalog.indirection.expects(:find).returns(@catalog)

        @apply.main
      end

      it "should transform the catalog to ral" do

        @catalog.expects(:to_ral).returns(@catalog)

        @apply.main
      end

      it "should finalize the catalog" do
        @catalog.expects(:finalize)

        @apply.main
      end

      it "should call the prerun and postrun commands on a Configurer instance" do
        Puppet::Configurer.any_instance.expects(:execute_prerun_command)
        Puppet::Configurer.any_instance.expects(:execute_postrun_command)

        @apply.main
      end

      it "should apply the catalog" do
        @catalog.expects(:apply).returns(stub_everything('transaction'))

        @apply.main
      end

      it "should save the last run summary" do
        Puppet.stubs(:[]).with(:noop).returns(false)
        report = Puppet::Transaction::Report.new("apply")
        Puppet::Transaction::Report.stubs(:new).returns(report)

        Puppet::Configurer.any_instance.expects(:save_last_run_summary).with(report)
        @apply.main
      end

      describe "with detailed_exitcodes" do
        it "should exit with report's computed exit status" do
          Puppet.stubs(:[]).with(:noop).returns(false)
          @apply.options.stubs(:[]).with(:detailed_exitcodes).returns(true)
          Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
          @apply.expects(:exit).with(666)

          @apply.main
        end

        it "should exit with report's computed exit status, even if --noop is set" do
          Puppet.stubs(:[]).with(:noop).returns(true)
          @apply.options.stubs(:[]).with(:detailed_exitcodes).returns(true)
          Puppet::Transaction::Report.any_instance.stubs(:exit_status).returns(666)
          @apply.expects(:exit).with(666)

          @apply.main
        end

        it "should always exit with 0 if option is disabled" do
          Puppet.stubs(:[]).with(:noop).returns(false)
          @apply.options.stubs(:[]).with(:detailed_exitcodes).returns(false)
          report = stub 'report', :exit_status => 666
          @transaction.stubs(:report).returns(report)
          @apply.expects(:exit).with(0)

          @apply.main
        end

        it "should always exit with 0 if --noop" do
          Puppet.stubs(:[]).with(:noop).returns(true)
          @apply.options.stubs(:[]).with(:detailed_exitcodes).returns(true)
          report = stub 'report', :exit_status => 666
          @transaction.stubs(:report).returns(report)
          @apply.expects(:exit).with(0)

          @apply.main
        end
      end
    end

    describe "the 'apply' command" do
      it "should read the catalog in from disk if a file name is provided" do
        @apply.options[:catalog] = "/my/catalog.pson"
        File.expects(:read).with("/my/catalog.pson").returns "something"
        Puppet::Resource::Catalog.stubs(:convert_from).with(:pson,'something').returns Puppet::Resource::Catalog.new
        @apply.apply
      end

      it "should read the catalog in from stdin if '-' is provided" do
        @apply.options[:catalog] = "-"
        $stdin.expects(:read).returns "something"
        Puppet::Resource::Catalog.stubs(:convert_from).with(:pson,'something').returns Puppet::Resource::Catalog.new
        @apply.apply
      end

      it "should deserialize the catalog from the default format" do
        @apply.options[:catalog] = "/my/catalog.pson"
        File.stubs(:read).with("/my/catalog.pson").returns "something"
        Puppet::Resource::Catalog.stubs(:default_format).returns :rot13_piglatin
        Puppet::Resource::Catalog.stubs(:convert_from).with(:rot13_piglatin,'something').returns Puppet::Resource::Catalog.new
        @apply.apply
      end

      it "should fail helpfully if deserializing fails" do
        @apply.options[:catalog] = "/my/catalog.pson"
        File.stubs(:read).with("/my/catalog.pson").returns "something syntacically invalid"
        lambda { @apply.apply }.should raise_error(Puppet::Error)
      end

      it "should convert plain data structures into a catalog if deserialization does not do so" do
        @apply.options[:catalog] = "/my/catalog.pson"
        File.stubs(:read).with("/my/catalog.pson").returns "something"
        Puppet::Resource::Catalog.stubs(:convert_from).with(:pson,"something").returns({:foo => "bar"})
        Puppet::Resource::Catalog.expects(:pson_create).with({:foo => "bar"}).returns(Puppet::Resource::Catalog.new)
        @apply.apply
      end

      it "should convert the catalog to a RAL catalog and use a Configurer instance to apply it" do
        @apply.options[:catalog] = "/my/catalog.pson"
        File.stubs(:read).with("/my/catalog.pson").returns "something"
        catalog = Puppet::Resource::Catalog.new
        Puppet::Resource::Catalog.stubs(:convert_from).with(:pson,'something').returns catalog
        catalog.expects(:to_ral).returns "mycatalog"

        configurer = stub 'configurer'
        Puppet::Configurer.expects(:new).returns configurer
        configurer.expects(:run).with(:catalog => "mycatalog")

        @apply.apply
      end
    end
  end
end