1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
|
require 'puppet/interface'
require 'puppet/interface/documentation'
require 'prettyprint'
class Puppet::Interface::Action
extend Puppet::Interface::DocGen
include Puppet::Interface::FullDocs
def initialize(face, name, attrs = {})
raise "#{name.inspect} is an invalid action name" unless name.to_s =~ /^[a-z]\w*$/
@face = face
@name = name.to_sym
# The few bits of documentation we actually demand. The default license
# is a favour to our end users; if you happen to get that in a core face
# report it as a bug, please. --daniel 2011-04-26
@authors = []
@license = 'All Rights Reserved'
attrs.each do |k, v| send("#{k}=", v) end
# @options collects the added options in the order they're declared.
# @options_hash collects the options keyed by alias for quick lookups.
@options = []
@options_hash = {}
@when_rendering = {}
end
# This is not nice, but it is the easiest way to make us behave like the
# Ruby Method object rather than UnboundMethod. Duplication is vaguely
# annoying, but at least we are a shallow clone. --daniel 2011-04-12
def __dup_and_rebind_to(to)
bound_version = self.dup
bound_version.instance_variable_set(:@face, to)
return bound_version
end
def to_s() "#{@face}##{@name}" end
attr_reader :name
attr_reader :face
attr_accessor :default
def default?
!!@default
end
########################################################################
# Documentation...
attr_doc :returns
attr_doc :arguments
def synopsis
build_synopsis(@face.name, default? ? nil : name, arguments)
end
########################################################################
# Support for rendering formats and all.
def when_rendering(type)
unless type.is_a? Symbol
raise ArgumentError, "The rendering format must be a symbol, not #{type.class.name}"
end
# Do we have a rendering hook for this name?
return @when_rendering[type].bind(@face) if @when_rendering.has_key? type
# How about by another name?
alt = type.to_s.sub(/^to_/, '').to_sym
return @when_rendering[alt].bind(@face) if @when_rendering.has_key? alt
# Guess not, nothing to run.
return nil
end
def set_rendering_method_for(type, proc)
unless proc.is_a? Proc
msg = "The second argument to set_rendering_method_for must be a Proc"
msg += ", not #{proc.class.name}" unless proc.nil?
raise ArgumentError, msg
end
if proc.arity != 1 then
msg = "when_rendering methods take one argument, the result, not "
if proc.arity < 0 then
msg += "a variable number"
else
msg += proc.arity.to_s
end
raise ArgumentError, msg
end
unless type.is_a? Symbol
raise ArgumentError, "The rendering format must be a symbol, not #{type.class.name}"
end
if @when_rendering.has_key? type then
raise ArgumentError, "You can't define a rendering method for #{type} twice"
end
# Now, the ugly bit. We add the method to our interface object, and
# retrieve it, to rotate through the dance of getting a suitable method
# object out of the whole process. --daniel 2011-04-18
@when_rendering[type] =
@face.__send__( :__add_method, __render_method_name_for(type), proc)
end
def __render_method_name_for(type)
:"#{name}_when_rendering_#{type}"
end
private :__render_method_name_for
attr_accessor :render_as
def render_as=(value)
@render_as = value.to_sym
end
########################################################################
# Initially, this was defined to allow the @action.invoke pattern, which is
# a very natural way to invoke behaviour given our introspection
# capabilities. Heck, our initial plan was to have the faces delegate to
# the action object for invocation and all.
#
# It turns out that we have a binding problem to solve: @face was bound to
# the parent class, not the subclass instance, and we don't pass the
# appropriate context or change the binding enough to make this work.
#
# We could hack around it, by either mandating that you pass the context in
# to invoke, or try to get the binding right, but that has probably got
# subtleties that we don't instantly think of – especially around threads.
#
# So, we are pulling this method for now, and will return it to life when we
# have the time to resolve the problem. For now, you should replace...
#
# @action = @face.get_action(name)
# @action.invoke(arg1, arg2, arg3)
#
# ...with...
#
# @action = @face.get_action(name)
# @face.send(@action.name, arg1, arg2, arg3)
#
# I understand that is somewhat cumbersome, but it functions as desired.
# --daniel 2011-03-31
#
# PS: This code is left present, but commented, to support this chunk of
# documentation, for the benefit of the reader.
#
# def invoke(*args, &block)
# @face.send(name, *args, &block)
# end
# We need to build an instance method as a wrapper, using normal code, to be
# able to expose argument defaulting between the caller and definer in the
# Ruby API. An extra method is, sadly, required for Ruby 1.8 to work since
# it doesn't expose bind on a block.
#
# Hopefully we can improve this when we finally shuffle off the last of Ruby
# 1.8 support, but that looks to be a few "enterprise" release eras away, so
# we are pretty stuck with this for now.
#
# Patches to make this work more nicely with Ruby 1.9 using runtime version
# checking and all are welcome, provided that they don't change anything
# outside this little ol' bit of code and all.
#
# Incidentally, we though about vendoring evil-ruby and actually adjusting
# the internal C structure implementation details under the hood to make
# this stuff work, because it would have been cleaner. Which gives you an
# idea how motivated we were to make this cleaner. Sorry.
# --daniel 2011-03-31
attr_reader :positional_arg_count
attr_accessor :when_invoked
def when_invoked=(block)
internal_name = "#{@name} implementation, required on Ruby 1.8".to_sym
arity = @positional_arg_count = block.arity
if arity == 0 then
# This will never fire on 1.8.7, which treats no arguments as "*args",
# but will on 1.9.2, which treats it as "no arguments". Which bites,
# because this just begs for us to wind up in the horrible situation
# where a 1.8 vs 1.9 error bites our end users. --daniel 2011-04-19
raise ArgumentError, "when_invoked requires at least one argument (options) for action #{@name}"
elsif arity > 0 then
range = Range.new(1, arity - 1)
decl = range.map { |x| "arg#{x}" } << "options = {}"
optn = ""
args = "[" + (range.map { |x| "arg#{x}" } << "options").join(", ") + "]"
else
range = Range.new(1, arity.abs - 1)
decl = range.map { |x| "arg#{x}" } << "*rest"
optn = "rest << {} unless rest.last.is_a?(Hash)"
if arity == -1 then
args = "rest"
else
args = "[" + range.map { |x| "arg#{x}" }.join(", ") + "] + rest"
end
end
file = __FILE__ + "+eval[wrapper]"
line = __LINE__ + 2 # <== points to the same line as 'def' in the wrapper.
wrapper = <<WRAPPER
def #{@name}(#{decl.join(", ")})
#{optn}
args = #{args}
action = get_action(#{name.inspect})
args << action.validate_and_clean(args.pop)
__invoke_decorations(:before, action, args, args.last)
rval = self.__send__(#{internal_name.inspect}, *args)
__invoke_decorations(:after, action, args, args.last)
return rval
end
WRAPPER
if @face.is_a?(Class)
@face.class_eval do eval wrapper, nil, file, line end
@face.define_method(internal_name, &block)
@when_invoked = @face.instance_method(name)
else
@face.instance_eval do eval wrapper, nil, file, line end
@face.meta_def(internal_name, &block)
@when_invoked = @face.method(name).unbind
end
end
def add_option(option)
option.aliases.each do |name|
if conflict = get_option(name) then
raise ArgumentError, "Option #{option} conflicts with existing option #{conflict}"
elsif conflict = @face.get_option(name) then
raise ArgumentError, "Option #{option} conflicts with existing option #{conflict} on #{@face}"
end
end
@options << option.name
option.aliases.each do |name|
@options_hash[name] = option
end
option
end
def option?(name)
@options_hash.include? name.to_sym
end
def options
@face.options + @options
end
def get_option(name, with_inherited_options = true)
option = @options_hash[name.to_sym]
if option.nil? and with_inherited_options
option = @face.get_option(name)
end
option
end
def validate_and_clean(original)
# The final set of arguments; effectively a hand-rolled shallow copy of
# the original, which protects the caller from the surprises they might
# get if they passed us a hash and we mutated it...
result = {}
# Check for multiple aliases for the same option, and canonicalize the
# name of the argument while we are about it.
overlap = Hash.new do |h, k| h[k] = [] end
unknown = []
original.keys.each do |name|
if option = get_option(name) then
canonical = option.name
if result.has_key? canonical
overlap[canonical] << name
else
result[canonical] = original[name]
end
elsif Puppet.settings.include? name
result[name] = original[name]
else
unknown << name
end
end
unless overlap.empty?
msg = overlap.map {|k, v| "(#{k}, #{v.sort.join(', ')})" }.join(", ")
raise ArgumentError, "Multiple aliases for the same option passed: #{msg}"
end
unless unknown.empty?
msg = unknown.sort.join(", ")
raise ArgumentError, "Unknown options passed: #{msg}"
end
# Inject default arguments and check for missing mandating options.
missing = []
options.map {|x| get_option(x) }.each do |option|
name = option.name
next if result.has_key? name
if option.has_default?
result[name] = option.default
elsif option.required?
missing << name
end
end
unless missing.empty?
msg = missing.sort.join(', ')
raise ArgumentError, "The following options are required: #{msg}"
end
# All done.
return result
end
########################################################################
# Support code for action decoration; see puppet/interface.rb for the gory
# details of why this is hidden away behind private. --daniel 2011-04-15
private
def __add_method(name, proc)
@face.__send__ :__add_method, name, proc
end
end
|