| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
evaluation time, rather than resource instantiation time. This
means that you don't catch your "errors" as early, but it also
means you should be able to realistically configure a whole host
in one run.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
any local variables and added a local variable -- see
http://snurl.com/21zf8. My own testing showed that this
caused memory growth to level off at a reasonable level.
Note that the link above says the problem is only with class
methods, but my own testing showed that it's any method that
meets these criteria. This is not a functional change, but
should hopefully be the last nail in the coffin of #1131.
|
|
|
|
|
|
|
|
|
|
| |
files, thanks to work by Adam Jacob and Arjuna Christenson
(the finding, not the leak). I'm going to act like this
fixes #1131, at least for now, but I doubt it does,
since that shows general memory growth over time, whereas
the leak here should go away as soon as files are reparsed
(because the parser is holding the reference to the leaking
array).
|
|
|
|
| |
388cf7c3df7ce26e953949ed6fe63d76cbbb3691 to resolve #1137; also, add tests which detect the problem.
|
| |
|
|
|
|
|
| |
circumstances (mostly, when loaded with other files, or
when loaded from rake or autotest rather than separately).
|
|
|
|
| |
When :node_name="cert" is specified the 'hostname' fact should be set to the SSL certificate common name instead of the results from facter. I've extended this to also set 'domain' and 'fqdn' since that makes a lot of sense to me. This fixes a regression introduced in SVN#1673
|
|
|
|
| |
(Patch by freiheit.)
|
|
|
|
|
|
| |
Note that this changes the behaviour a bit -- the resource's
noop setting always beats the global setting (previously,
whichever was true would win).
|
|
|
|
|
|
| |
stacked metaparameter values do not result in all resources
that receive a given default also getting those stacked
values.
|
| |
|
| |
|
|
|
|
| |
thus breaking some of them.
|
| |
|
|
|
|
|
|
|
| |
in the Exec resource type -- the log levels are specified
using the 'loglevel' parameter, not 'logoutput'. This never
worked, or at least hasn't for ages, and now the docs are
just correct.
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
any objects, nor does it use Puppet's RAL resources. In the
process, I fixed #894 (you can now copy links) and refactored
other classes as necessary. Mostly it was fixing tests.
This is a squashed commit of a temporary branch, fwiw,
and it also includes any fixes to the tests that were
necessary to get all tests passing again.
|
| |
|
| |
|
|
|
|
| |
from modules even when Autoload#loadall is used.
|
|
|
|
|
|
| |
in each module, in addition to the lib directory. The 'lib'
directory is also deprecated, but supported for now to give
people a chance to convert.
|
|
|
|
|
| |
including not compiling the configurations, and also storeconfigs
is no longer required during parse-testing.
|
|
|
|
|
| |
'file' and 'filebucket'. This should have been done
years ago.
|
| |
|
| |
|
|
|
|
|
|
|
| |
NOTE: This introduces a behaviour change, in that you previously
could realize a resource within a virtual defined resource, and now
you must realize the entire defined resource, rather than just
the contained resource.
|
|
|
|
|
|
|
| |
*sworn* I did this weekend). In the process, I fixed
a couple of bugs related to differentiating between
nodes and classes, and then cleaned up quite a few
error messages.
|
|
|
|
| |
removing the bangs from 'add_vertex!' and 'add_edge!'.
|
|
|
|
|
| |
since it's stupid to have a class named after
a verb.
|
|
|
|
|
| |
be more internally consistent (switched store_resource
to add_resource, and store_override to add_override).
|
|
|
|
|
|
| |
refactored, fixing this problem and making the whole interplay
between the classes, definitions, and nodes, and the Compile class much
cleaner.
|
|
|
|
|
| |
as its resource container, instead of having its own behaviour
around resource uniqueness.
|
|
|
|
|
|
| |
rspec, so I can refactor the class to more heavily rely
on a Node::Catalog instead of doing its own resource
container management.
|
|
|
|
|
|
|
|
|
|
|
| |
just returns a resource from its evaluate() method, and
all of the work is done in the evaluate_code method. This
makes the code cleaner, because it means 1) evaluate() has
the same prototype as all of the other AST classes,
2) evaluate() is no longer called indirectly through
the Parser Resource class, and 3) the classes themselves
are responsible for creating the resources, rather than
it being done in the Compile class.
|
|
|
|
|
|
| |
all of the evaluate() methods only ever accepted a scope,
and sometimes one other option, so I switched them all to
use named arguments instead of a hash.
|
|
|
|
| |
no network
|
|
|
|
| |
deprecation. :env parameter sets new :environment parameter. Changed instances of :env to :environment for consistency with other types. Added tests for new parameters. This cimmit fixes ticket 1007.
|
|\ |
|
| | |
|
|\| |
|
| | |
|
|/
|
|
| |
longer ignored. (Cherry-picked from master.)
|
|
|
|
|
|
| |
classes for managing how the tokens work.
I also moved they tests to RSpec, but I didn't rewrite all of them.
|
|
|
|
|
| |
and one that somehow slipped through when I removed the GRATR
code.
|
|
|
|
| |
from the system, and implemented my own topsort method.
|
|
|
|
| |
of stripping extra and trailing slashes.
|
|
|
|
|
|
|
| |
caused other problems.
This whole thing will hopefully get *drastically* easier once we
get rid of global resources.
|
|
|
|
| |
managed resources.
|