summaryrefslogtreecommitdiffstats
path: root/lib/puppet/parser/ast
diff options
context:
space:
mode:
Diffstat (limited to 'lib/puppet/parser/ast')
-rw-r--r--lib/puppet/parser/ast/ifstatement.rb6
-rw-r--r--lib/puppet/parser/ast/match_operator.rb3
-rw-r--r--lib/puppet/parser/ast/resource_override.rb3
-rw-r--r--lib/puppet/parser/ast/resource_reference.rb3
4 files changed, 4 insertions, 11 deletions
diff --git a/lib/puppet/parser/ast/ifstatement.rb b/lib/puppet/parser/ast/ifstatement.rb
index 36da50c7a..cbb61bf9c 100644
--- a/lib/puppet/parser/ast/ifstatement.rb
+++ b/lib/puppet/parser/ast/ifstatement.rb
@@ -24,11 +24,7 @@ class Puppet::Parser::AST
if Puppet::Parser::Scope.true?(value)
return @statements.safeevaluate(scope)
else
- if defined?(@else)
- return @else.safeevaluate(scope)
- else
- return nil
- end
+ return defined?(@else) ? @else.safeevaluate(scope) : nil
end
ensure
scope.unset_ephemeral_var(level)
diff --git a/lib/puppet/parser/ast/match_operator.rb b/lib/puppet/parser/ast/match_operator.rb
index 9a12351b9..2ab2befd4 100644
--- a/lib/puppet/parser/ast/match_operator.rb
+++ b/lib/puppet/parser/ast/match_operator.rb
@@ -16,8 +16,7 @@ class Puppet::Parser::AST
def evaluate(scope)
lval = @lval.safeevaluate(scope)
- return @operator == "=~" if rval.evaluate_match(lval, scope)
- return @operator == "!~"
+ return(rval.evaluate_match(lval, scope) ? @operator == "=~" : @operator == "!~")
end
def initialize(hash)
diff --git a/lib/puppet/parser/ast/resource_override.rb b/lib/puppet/parser/ast/resource_override.rb
index f9071fe96..7f7047dd9 100644
--- a/lib/puppet/parser/ast/resource_override.rb
+++ b/lib/puppet/parser/ast/resource_override.rb
@@ -54,8 +54,7 @@ class Puppet::Parser::AST
res
end
# decapsulate array in case of only one item
- return resource.pop if resource.length == 1
- return resource
+ return(resource.length == 1 ? resource.pop : resource)
end
# Create our ResourceDef. Handles type checking for us.
diff --git a/lib/puppet/parser/ast/resource_reference.rb b/lib/puppet/parser/ast/resource_reference.rb
index d2f9b2ce4..37e82d568 100644
--- a/lib/puppet/parser/ast/resource_reference.rb
+++ b/lib/puppet/parser/ast/resource_reference.rb
@@ -8,8 +8,7 @@ class Puppet::Parser::AST::ResourceReference < Puppet::Parser::AST::Branch
# and name.
def evaluate(scope)
titles = Array(title.safeevaluate(scope)).collect { |t| Puppet::Resource.new(type, t, :namespaces => scope.namespaces) }
- return titles.pop if titles.length == 1
- return titles
+ return(titles.length == 1 ? titles.pop : titles)
end
def to_s