Fixing #2403 - provider specificity is richer and better

We have extended the concept of provider specificity so it
now includes both specified defaults and class depth, so:

* We are much more likely to choose the correct provider;
  e.g., 'init' will be chosen over 'base'

* We're much less likely to print this warning, because it's
  only printed when provider specificities are equal which
  is much rarer

lib/puppet/provider.rb   |    4 ++--
lib/puppet/type.rb       |    4 ++--
spec/unit/type.rb        |   17 +++++++++++++++++
test/ral/manager/type.rb |   22 ----------------------
4 files changed, 21 insertions(+), 26 deletions(-)

Signed-off-by: Luke Kanies <luke@madstop.com>

1 files changed, 0 insertions, 22 deletions

diff --git a/test/ral/manager/type.rb b/test/ral/manager/type.rb
index 2624e26ea..30da6d114 100755
--- a/test/ral/manager/type.rb
+++ b/test/ral/manager/type.rb
@@ -307,28 +307,6 @@ class TestType < Test::Unit::TestCase
         assert_equal(path, file[:name], "Did not get correct name")
     end
 
-    # Make sure default providers behave correctly
-    def test_defaultproviders
-        # Make a fake type
-        type = Puppet::Type.newtype(:defaultprovidertest) do
-            newparam(:name) do end
-        end
-
-        basic = type.provide(:basic) do
-            defaultfor :operatingsystem => :somethingelse,
-                :operatingsystemrelease => :yayness
-        end
-
-        assert_equal(basic, type.defaultprovider)
-        type.defaultprovider = nil
-
-        greater = type.provide(:greater) do
-            defaultfor :operatingsystem => Facter.value("operatingsystem")
-        end
-
-        assert_equal(greater, type.defaultprovider)
-    end
-
     # Make sure that we can have multiple non-isomorphic objects with the same name,
     # but not with isomorphic objects.
     def test_isomorphic_names