Adding a fact handler, along with an abstract interface for fact stores and a simple yaml fact store, towards the Node Classification work.

git-svn-id: https://reductivelabs.com/svn/puppet/trunk@2457 980ebf18-57e1-0310-9a29-db15c13687c0

2 files changed, 179 insertions, 0 deletions

diff --git a/test/network/handler/facts.rb b/test/network/handler/facts.rb
new file mode 100755
index 000000000..03327b8c4
--- /dev/null
+++ b/test/network/handler/facts.rb
@@ -0,0 +1,112 @@
+#!/usr/bin/env ruby
+
+$:.unshift("../../lib") if __FILE__ =~ /\.rb$/
+
+require 'puppettest'
+require 'mocha'
+require 'puppet/network/handler/facts'
+
+class TestFactsHandler < Test::Unit::TestCase
+    include PuppetTest::ServerTest
+
+    def setup
+        super
+
+        @class = Puppet::Network::Handler.handler(:facts)
+
+        @@client_facts = {}
+
+        unless Puppet::Util::FactStore.store(:testing)
+            Puppet::Util::FactStore.newstore(:testing) do
+                def get(node)
+                    @@client_facts[node]
+                end
+
+                def set(node, facts)
+                    @@client_facts[node] = facts
+                end
+            end
+        end
+
+        Puppet[:factstore] = :testing
+
+        @handler = @class.new
+
+        @facts = {:a => :b, :c => :d}
+        @name = "foo"
+
+        @backend = @handler.instance_variable_get("@backend")
+    end
+
+    def teardown
+        @@client_facts.clear
+    end
+
+    def test_strip_internal
+        @facts[:_puppet_one] = "yay"
+        @facts[:_puppet_two] = "boo"
+        @facts[:_puppetthree] = "foo"
+
+        newfacts = nil
+        assert_nothing_raised("Could not call strip_internal") do
+            newfacts = @handler.send(:strip_internal, @facts)
+        end
+
+        [:_puppet_one, :_puppet_two, :_puppetthree].each do |name|
+            assert(@facts.include?(name), "%s was removed in strip_internal from original hash" % name)
+        end
+        [:_puppet_one, :_puppet_two].each do |name|
+            assert(! newfacts.include?(name), "%s was not removed in strip_internal" % name)
+        end
+        assert_equal("foo", newfacts[:_puppetthree], "_puppetthree was removed in strip_internal")
+    end
+
+    def test_add_internal
+        newfacts = nil
+        assert_nothing_raised("Could not call strip_internal") do
+            newfacts = @handler.send(:add_internal, @facts)
+        end
+
+        assert_instance_of(Time, newfacts[:_puppet_timestamp], "Did not set timestamp in add_internal")
+        assert(! @facts.include?(:_puppet_timestamp), "Modified original hash in add_internal")
+    end
+
+    def test_set
+        newfacts = @facts.dup
+        newfacts[:_puppet_timestamp] = Time.now
+        @handler.expects(:add_internal).with(@facts).returns(newfacts)
+        @backend.expects(:set).with(@name, newfacts).returns(nil)
+
+        assert_nothing_raised("Could not set facts") do
+            assert_nil(@handler.set(@name, @facts), "handler.set did not return nil")
+        end
+    end
+
+    def test_get
+        prefacts = @facts.dup
+        prefacts[:_puppet_timestamp] = Time.now
+        @@client_facts[@name] = prefacts
+        @handler.expects(:strip_internal).with(prefacts).returns(@facts)
+        @backend.expects(:get).with(@name).returns(prefacts)
+
+        assert_nothing_raised("Could not retrieve facts") do
+            assert_equal(@facts,  @handler.get(@name), "did not get correct answer from handler.get")
+        end
+
+        @handler = @class.new
+        assert_nothing_raised("Failed to call 'get' with no stored facts") do
+            @handler.get("nosuchname")
+        end
+    end
+
+    def test_store_date
+        time = Time.now
+        @facts[:_puppet_timestamp] = time
+
+        @handler.expects(:get).with(@name).returns(@facts)
+
+        assert_equal(time.to_i, @handler.store_date(@name), "Did not retrieve timestamp correctly")
+    end
+end
+
+# $Id$
diff --git a/test/util/fact_store.rb b/test/util/fact_store.rb
new file mode 100755
index 000000000..5b04d1374
--- /dev/null
+++ b/test/util/fact_store.rb
@@ -0,0 +1,67 @@
+#!/usr/bin/env ruby
+#
+#  Created by Luke Kanies on 2007-05-02.
+#  Copyright (c) 2007. All rights reserved.
+
+$:.unshift("../lib").unshift("../../lib") if __FILE__ =~ /\.rb$/
+
+require 'puppettest'
+require 'puppet/util/fact_store'
+
+class TestFactStore < Test::Unit::TestCase
+	include PuppetTest
+	
+	def test_new_fact_store
+        klass = nil
+        assert_nothing_raised("Could not create fact store") do
+            klass = Puppet::Util::FactStore.newstore(:yay) do
+            end
+        end
+
+        assert_equal(klass, Puppet::Util::FactStore.store(:yay), "Did not get created store back by name")
+    end
+
+    def test_yaml_store
+        yaml = Puppet::Util::FactStore.store(:yaml)
+        assert(yaml, "Could not retrieve yaml store")
+
+        name = "node"
+        facts = {"a" => :b, :c => "d", :e => :f, "g" => "h"}
+
+        store = nil
+        assert_nothing_raised("Could not create YAML store instance") do
+            store = yaml.new 
+        end
+
+        assert_nothing_raised("Could not store host facts") do
+            store.set(name, facts)
+        end
+
+        dir = Puppet[:yamlfactdir]
+
+        file = File.join(dir, name + ".yaml")
+        assert(FileTest.exists?(file), "Did not create yaml file for node")
+
+        text = File.read(file)
+        newfacts = nil
+        assert_nothing_raised("Could not deserialize yaml") do
+            newfacts = YAML::load(text)
+        end
+
+        # Don't directly compare the hashes, because there might be extra
+        # data stored in the client hash
+        facts.each do |var, value|
+            assert_equal(value, newfacts[var], "Value for %s changed during storage" % var)
+        end
+
+        # Now make sure the facts get retrieved correctly
+        assert_nothing_raised("Could not retrieve facts") do
+            newfacts = store.get(name)
+        end
+
+        # Now make sure the hashes are equal, since internal facts should not be returned.
+        assert_equal(facts, newfacts, "Retrieved facts are not equal")
+    end
+end
+
+# $Id$