summaryrefslogtreecommitdiffstats
path: root/test/network
diff options
context:
space:
mode:
authorMarkus Roberts <Markus@reality.com>2010-07-09 18:06:58 -0700
committerMarkus Roberts <Markus@reality.com>2010-07-09 18:06:58 -0700
commit8f15707251cdb58d53e82c4bbd332a38c2d31b4c (patch)
treeb4a5df05fb8121c498cd33b67516d69af3d9853b /test/network
parentc3e2353afb7fc2fb12efd1eb2bc5c342c792fb3b (diff)
downloadpuppet-8f15707251cdb58d53e82c4bbd332a38c2d31b4c.tar.gz
puppet-8f15707251cdb58d53e82c4bbd332a38c2d31b4c.tar.xz
puppet-8f15707251cdb58d53e82c4bbd332a38c2d31b4c.zip
Code smell: Don't restate results directly after assignment
Replaced 33 occurances of ([$@]?\w+)( +[|&+-]{0,2}= .+) \1 end with 3 Examples: The code: @sync ||= Sync.new @sync end becomes: @sync ||= Sync.new end The code: str += "\n" str end becomes: str += "\n" end The code: @indirection = Puppet::Indirector::Indirection.new(self, indirection, options) @indirection end becomes: @indirection = Puppet::Indirector::Indirection.new(self, indirection, options) end
Diffstat (limited to 'test/network')
-rwxr-xr-xtest/network/authorization.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/test/network/authorization.rb b/test/network/authorization.rb
index 680d5676d..cecc1fd8d 100755
--- a/test/network/authorization.rb
+++ b/test/network/authorization.rb
@@ -48,7 +48,6 @@ class TestAuthConfig < Test::Unit::TestCase
class << @obj
def authconfig
@authconfig ||= FakeAuth.new
- @authconfig
end
end
@request = Puppet::Network::ClientRequest.new("host", "ip", false)