summaryrefslogtreecommitdiffstats
path: root/tasks/rake/git_workflow.rake
diff options
context:
space:
mode:
authorBrice Figureau <brice-puppet@daysofwonder.com>2011-03-26 16:14:15 +0100
committerBrice Figureau <brice-puppet@daysofwonder.com>2011-03-26 16:48:45 +0100
commit37f9ca09135330ed180fb68d9295a4967a5cc857 (patch)
treeb478ebb21e1b860df27109f0dcd836039761e58d /tasks/rake/git_workflow.rake
parent76b3ee6822f52b100c45cd8921f13739f12ddf38 (diff)
downloadpuppet-37f9ca09135330ed180fb68d9295a4967a5cc857.tar.gz
puppet-37f9ca09135330ed180fb68d9295a4967a5cc857.tar.xz
puppet-37f9ca09135330ed180fb68d9295a4967a5cc857.zip
(#6862) Add a default subject for the mail_patches rake task
This will prevent committers to forget to write cover letter subject when rake mail_patches needs to send multiple e-mails. It defaults to the "type" and "branch name" of the patch-set. Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
Diffstat (limited to 'tasks/rake/git_workflow.rake')
-rw-r--r--tasks/rake/git_workflow.rake4
1 files changed, 3 insertions, 1 deletions
diff --git a/tasks/rake/git_workflow.rake b/tasks/rake/git_workflow.rake
index 980d2fbce..f2ae7ee69 100644
--- a/tasks/rake/git_workflow.rake
+++ b/tasks/rake/git_workflow.rake
@@ -108,12 +108,14 @@ task :mail_patches do
# If we've got more than one patch, add --compose
if Dir.glob("00*.patch").length > 1
compose = "--compose"
+ subject = "--subject \"#{type} #{name} against #{parent}\""
else
compose = ""
+ subject = ""
end
# Now send the mail.
- sh "git send-email #{compose} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch"
+ sh "git send-email #{compose} #{subject} --no-signed-off-by-cc --suppress-from --to puppet-dev@googlegroups.com 00*.patch"
# Finally, clean up the patches
sh "rm 00*.patch"