Fixing a heisenbug resulting from a race condition

We had a case where an expectation could be triggered
before the thread finished, in which case it was marked
as a failure.

We just stub the Thread.new to avoid creating a "real"
thread, thus skipping the race condition.

Signed-off-by: Luke Kanies <luke@madstop.com>

1 files changed, 3 insertions, 1 deletions

diff --git a/spec/unit/network/http/webrick.rb b/spec/unit/network/http/webrick.rb
index d0c4b5562..1b76341ba 100755
--- a/spec/unit/network/http/webrick.rb
+++ b/spec/unit/network/http/webrick.rb
@@ -40,8 +40,10 @@ describe Puppet::Network::HTTP::WEBrick, "when turning on listening" do
         Proc.new { @server.listen(@listen_params.delete_if {|k,v| :port == k})}.should raise_error(ArgumentError)
     end
 
-    it "should order a webrick server to start" do
+    it "should order a webrick server to start in a separate thread" do
         @mock_webrick.expects(:start)
+        # If you remove this you'll sometimes get race condition problems
+        Thread.expects(:new).yields
         @server.listen(@listen_params)
     end