maint: Fix inspect help

Running `puppet help inspect` did not result in help:

    Unable to find application 'inspect'.
    err: exit
    err: Try 'puppet help help help' for usage

It turned out that the only reason applications were getting required so
that their help could be found was the LegacyName conversion table in
lib/puppet/util/command_line.rb:7.  Inspect never had a legacy name, so
the help system couldn't find it since it never got required.  Now
instead of checking for the class constant to see if the application has
been loaded, we try to require the application and exit if it's not
found.

Reviewed-by: Nick Lewis <nick@puppetlabs.com>

1 files changed, 4 insertions, 0 deletions

diff --git a/spec/unit/application_spec.rb b/spec/unit/application_spec.rb
index aed80e3e6..b56aa20b0 100755
--- a/spec/unit/application_spec.rb
+++ b/spec/unit/application_spec.rb
@@ -31,6 +31,10 @@ describe Puppet::Application do
     end
 
     it "should exit if it can't find a class" do
+      reg = "Unable to find application 'ThisShallNeverEverEverExist'.  "
+      reg += "no such file to load -- puppet/application/ThisShallNeverEverEverExist"
+      @klass.expects(:puts).with(reg)
+
       expect { @klass.find("ThisShallNeverEverEverExist") }.to exit_with 1
     end
   end