Fixing #2541 - file cache is more resilient to failure

Signed-off-by: Luke Kanies <luke@madstop.com>

1 files changed, 30 insertions, 0 deletions

diff --git a/spec/unit/util/autoload/file_cache.rb b/spec/unit/util/autoload/file_cache.rb
index 333ddb545..59620ed2d 100755
--- a/spec/unit/util/autoload/file_cache.rb
+++ b/spec/unit/util/autoload/file_cache.rb
@@ -31,6 +31,21 @@ describe Puppet::Util::Autoload::FileCache do
             @cacher.should_not be_file_exist("/my/file")
         end
 
+        it "should consider a file as absent if the directory is absent" do
+            File.expects(:lstat).with("/my/file").raises Errno::ENOTDIR
+            @cacher.should_not be_file_exist("/my/file")
+        end
+
+        it "should consider a file as absent permissions are missing" do
+            File.expects(:lstat).with("/my/file").raises Errno::EACCES
+            @cacher.should_not be_file_exist("/my/file")
+        end
+
+        it "should raise non-fs exceptions" do
+            File.expects(:lstat).with("/my/file").raises ArgumentError
+            lambda { @cacher.file_exist?("/my/file") }.should raise_error(ArgumentError)
+        end
+
         it "should consider a file as present if its lstat succeeds" do
             File.expects(:lstat).with("/my/file").returns mock("stat")
             @cacher.should be_file_exist("/my/file")
@@ -87,6 +102,21 @@ describe Puppet::Util::Autoload::FileCache do
             @cacher.should_not be_directory_exist("/my/file")
         end
 
+        it "should consider a file as absent if the directory is absent" do
+            File.expects(:lstat).with("/my/file").raises Errno::ENOTDIR
+            @cacher.should_not be_directory_exist("/my/file")
+        end
+
+        it "should consider a file as absent permissions are missing" do
+            File.expects(:lstat).with("/my/file").raises Errno::EACCES
+            @cacher.should_not be_directory_exist("/my/file")
+        end
+
+        it "should raise non-fs exceptions" do
+            File.expects(:lstat).with("/my/file").raises ArgumentError
+            lambda { @cacher.directory_exist?("/my/file") }.should raise_error(ArgumentError)
+        end
+
         it "should consider a directory as present if its lstat succeeds and the stat is of a directory" do
             @stat.expects(:directory?).returns true
             File.expects(:lstat).with("/my/file").returns @stat