Fix #3656 JSON serialization of dependencies

The pson serialization of resources was behaving incorrectly on
parameters that are references to other resources:
1. Dependency parameters (require, subscribe, notify) were getting
serialized as anonymous objects that looked like partially constructed
resources
2. During de-serialization the pson parser would inflate them
into hashes (rather than into resources)
3. The outer resource would try to coerce the hash into a resource by
passing it to Resource.new
4. Resource.new would fail with a cryptic message, since it does not
accept a hash as its first parameter (but the error is obfuscated by
Resource.new's complicated argument handler)

This patch solves the problem by explicitly converting dependency
parameters into strings in the pson serialization.

Signed-off-by: Jesse Wolfe <jes5199@gmail.com>

1 files changed, 7 insertions, 0 deletions

diff --git a/spec/unit/resource.rb b/spec/unit/resource.rb
index 0eacd0b90..3840db535 100755
--- a/spec/unit/resource.rb
+++ b/spec/unit/resource.rb
@@ -664,6 +664,13 @@ describe Puppet::Resource do
             result["foo"].should == %w{bar eh}
             result["fee"].should == %w{baz}
         end
+
+        it "should serialize relationships as reference strings" do
+            resource = Puppet::Resource.new("File", "/foo")
+            resource[:requires] = Puppet::Resource.new("File", "/bar")
+            result = Puppet::Resource.from_pson(PSON.parse(resource.to_pson))
+            result[:requires].should == "File[/bar]"
+        end
     end
 
     describe "when converting from pson" do