Doing a small amount of refactoring, toward being able to use Parser resources to evaluate classes and nodes, not just definitions. This will hopefully simplify some of the parsing work, and it will enable the use of a Configuration object that more completely models a configuration.

2 files changed, 105 insertions, 0 deletions

diff --git a/spec/unit/parser/resource.rb b/spec/unit/parser/resource.rb
new file mode 100755
index 000000000..354690711
--- /dev/null
+++ b/spec/unit/parser/resource.rb
@@ -0,0 +1,39 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+# LAK: FIXME This is just new tests for resources; I have
+# not moved all tests over yet.
+describe Puppet::Parser::Resource, " when evaluating" do
+    before do
+        @type = Puppet::Parser::Resource
+
+        @parser = Puppet::Parser::Parser.new :Code => ""
+        @source = @parser.newclass ""
+        @definition = @parser.newdefine "mydefine"
+        @class = @parser.newclass "myclass"
+        @nodedef = @parser.newnode("mynode")[0]
+        @node = Puppet::Node.new("yaynode")
+        @compile = Puppet::Parser::Compile.new(@node, @parser)
+        @scope = @compile.topscope
+    end
+
+    it "should evaluate the associated AST definition" do
+        res = @type.new(:type => "mydefine", :title => "whatever", :scope => @scope, :source => @source)
+        @definition.expects(:evaluate).with(:scope => @scope, :resource => res)
+
+        res.evaluate
+    end
+
+    it "should evaluate the associated AST class" do
+        res = @type.new(:type => "class", :title => "myclass", :scope => @scope, :source => @source)
+        @class.expects(:evaluate).with(:scope => @scope, :resource => res)
+        res.evaluate
+    end
+
+    it "should evaluate the associated AST node" do
+        res = @type.new(:type => "node", :title => "mynode", :scope => @scope, :source => @source)
+        @nodedef.expects(:evaluate).with(:scope => @scope, :resource => res)
+        res.evaluate
+    end
+end
diff --git a/spec/unit/parser/resource/reference.rb b/spec/unit/parser/resource/reference.rb
new file mode 100755
index 000000000..45af3d938
--- /dev/null
+++ b/spec/unit/parser/resource/reference.rb
@@ -0,0 +1,66 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../../../spec_helper'
+
+describe Puppet::Parser::Resource::Reference do
+    before do
+        @type = Puppet::Parser::Resource::Reference
+    end
+
+    it "should require a type" do
+        proc { @type.new(:title => "yay") }.should raise_error(Puppet::DevError)
+    end
+
+    it "should require a title" do
+        proc { @type.new(:type => "file") }.should raise_error(Puppet::DevError)
+    end
+
+    it "should know when it models a builtin type" do
+        ref = @type.new(:type => "file", :title => "/tmp/yay")
+        ref.builtin?.should be_true
+        ref.builtintype.should equal(Puppet::Type.type(:file))
+    end
+
+    it "should return a relationship-style resource reference when asked" do
+        ref = @type.new(:type => "file", :title => "/tmp/yay")
+        ref.to_ref.should == ["file", "/tmp/yay"]
+    end
+
+    it "should return a resource reference string when asked" do
+        ref = @type.new(:type => "file", :title => "/tmp/yay")
+        ref.to_s.should == "File[/tmp/yay]"
+    end
+end
+
+describe Puppet::Parser::Resource::Reference, " when modeling defined types" do
+    before do
+        @type = Puppet::Parser::Resource::Reference
+
+        @parser = Puppet::Parser::Parser.new :Code => ""
+        @definition = @parser.newdefine "mydefine"
+        @class = @parser.newclass "myclass"
+        @nodedef = @parser.newnode("mynode")[0]
+        @node = Puppet::Node.new("yaynode")
+
+        @compile = Puppet::Parser::Compile.new(@node, @parser)
+    end
+
+    it "should be able to model definitions" do
+        ref = @type.new(:type => "mydefine", :title => "/tmp/yay", :scope => @compile.topscope)
+        ref.builtin?.should be_false
+        ref.definedtype.should equal(@definition)
+    end
+
+    it "should be able to model classes" do
+        ref = @type.new(:type => "class", :title => "myclass", :scope => @compile.topscope)
+        ref.builtin?.should be_false
+        ref.definedtype.should equal(@class)
+    end
+
+    it "should be able to model nodes" do
+        ref = @type.new(:type => "node", :title => "mynode", :scope => @compile.topscope)
+        ref.builtin?.should be_false
+        ref.definedtype.object_id.should  == @nodedef.object_id
+    end
+end
+