summaryrefslogtreecommitdiffstats
path: root/spec/unit
diff options
context:
space:
mode:
authorMax Martin <max@puppetlabs.com>2011-04-21 16:53:26 -0700
committerMax Martin <max@puppetlabs.com>2011-04-21 16:54:05 -0700
commitaaf7e2300b12a0ef03b620efc5eea7af0dc6f71b (patch)
treef4a103aa99e292f93359640455009ec9011fe09e /spec/unit
parent17d176b9a9be0d85f74b61d67ab6ad0f76013dbc (diff)
downloadpuppet-aaf7e2300b12a0ef03b620efc5eea7af0dc6f71b.tar.gz
puppet-aaf7e2300b12a0ef03b620efc5eea7af0dc6f71b.tar.xz
puppet-aaf7e2300b12a0ef03b620efc5eea7af0dc6f71b.zip
Revert "(7080) Adding json support to Indirector Request"
This reverts commit e0615cbc1eea67ef8caf4edbc8b7b3d3ce618f4d. The JSON patch series has caused problems with the inventory service, and further discussion is needed to decide how to serialize objects to PSON with regards to future compatibility. Conflicts: spec/unit/indirector/request_spec.rb Paired-with:Matt Robinson <matt@puppetlabs.com>
Diffstat (limited to 'spec/unit')
-rwxr-xr-xspec/unit/indirector/request_spec.rb95
1 files changed, 0 insertions, 95 deletions
diff --git a/spec/unit/indirector/request_spec.rb b/spec/unit/indirector/request_spec.rb
index ba7dc815e..87b9af438 100755
--- a/spec/unit/indirector/request_spec.rb
+++ b/spec/unit/indirector/request_spec.rb
@@ -301,99 +301,4 @@ describe Puppet::Indirector::Request do
lambda { @request.query_string }.should raise_error(ArgumentError)
end
end
-
- describe "when converting to json" do
- before do
- @request = Puppet::Indirector::Request.new(:facts, :find, "foo")
- end
-
- it "should produce a hash with the document_type set to 'request'" do
- @request.should set_json_document_type_to("Puppet::Indirector::Request")
- end
-
- it "should set the 'key'" do
- @request.should set_json_attribute("key").to("foo")
- end
-
- it "should include an attribute for its indirection name" do
- @request.should set_json_attribute("type").to("facts")
- end
-
- it "should include a 'method' attribute set to its method" do
- @request.should set_json_attribute("method").to("find")
- end
-
- it "should add all attributes under the 'attributes' attribute" do
- @request.ip = "127.0.0.1"
- @request.should set_json_attribute("attributes", "ip").to("127.0.0.1")
- end
-
- it "should add all options under the 'attributes' attribute" do
- @request.options["opt"] = "value"
- PSON.parse(@request.to_pson)["data"]['attributes']['opt'].should == "value"
- end
-
- it "should include the instance if provided" do
- facts = Puppet::Node::Facts.new("foo")
- @request.instance = facts
- PSON.parse(@request.to_pson)["data"]['instance'].should be_instance_of(Puppet::Node::Facts)
- end
- end
-
- describe "when converting from json" do
- before do
- @request = Puppet::Indirector::Request.new(:facts, :find, "foo")
- @klass = Puppet::Indirector::Request
- @format = Puppet::Network::FormatHandler.format('pson')
- end
-
- def from_json(json)
- @format.intern(Puppet::Indirector::Request, json)
- end
-
- it "should set the 'key'" do
- from_json(@request.to_pson).key.should == "foo"
- end
-
- it "should fail if no key is provided" do
- json = PSON.parse(@request.to_pson)
- json['data'].delete("key")
- lambda { from_json(json.to_pson) }.should raise_error(ArgumentError)
- end
-
- it "should set its indirector name" do
- from_json(@request.to_pson).indirection_name.should == :facts
- end
-
- it "should fail if no type is provided" do
- json = PSON.parse(@request.to_pson)
- json['data'].delete("type")
- lambda { from_json(json.to_pson) }.should raise_error(ArgumentError)
- end
-
- it "should set its method" do
- from_json(@request.to_pson).method.should == "find"
- end
-
- it "should fail if no method is provided" do
- json = PSON.parse(@request.to_pson)
- json['data'].delete("method")
- lambda { from_json(json.to_pson) }.should raise_error(ArgumentError)
- end
-
- it "should initialize with all attributes and options" do
- @request.ip = "127.0.0.1"
- @request.options["opt"] = "value"
- result = from_json(@request.to_pson)
- result.options[:opt].should == "value"
- result.ip.should == "127.0.0.1"
- end
-
- it "should set its instance as an instance if one is provided" do
- facts = Puppet::Node::Facts.new("foo")
- @request.instance = facts
- result = from_json(@request.to_pson)
- result.instance.should be_instance_of(Puppet::Node::Facts)
- end
- end
end