summaryrefslogtreecommitdiffstats
path: root/spec/unit/util/network_device
diff options
context:
space:
mode:
authorMatt Robinson <matt@puppetlabs.com>2011-05-16 16:10:21 -0700
committerMatt Robinson <matt@puppetlabs.com>2011-05-17 09:57:26 -0700
commit9da1454e71b8330e929ac5616eefa44388c90832 (patch)
tree8055105961771b9b95a4b888c0599b26000603d6 /spec/unit/util/network_device
parent47e4ac948504aa6fbd3487ca1b1e19f3c8884a79 (diff)
downloadpuppet-9da1454e71b8330e929ac5616eefa44388c90832.tar.gz
puppet-9da1454e71b8330e929ac5616eefa44388c90832.tar.xz
puppet-9da1454e71b8330e929ac5616eefa44388c90832.zip
(#7507) Add ability to filter Ruby 1.9 spec failures
By running: rspec spec --tag ~@fails_on_ruby_1.9.2 We can now just run the specs that pass under Ruby 1.9. Obviously in the long term we want to have all the specs passing, but until then we need notification when we regress. From now on new code will be required to pass under Ruby 1.9, and Jenkins will give us email notification if it doesn't or if we break something that was already working. Reviewed-by: Daniel Pittman <daniel@puppetlabs.com>
Diffstat (limited to 'spec/unit/util/network_device')
-rwxr-xr-xspec/unit/util/network_device/cisco/device_spec.rb4
-rwxr-xr-xspec/unit/util/network_device/transport/ssh_spec.rb2
2 files changed, 3 insertions, 3 deletions
diff --git a/spec/unit/util/network_device/cisco/device_spec.rb b/spec/unit/util/network_device/cisco/device_spec.rb
index 33242a1ab..8971205d3 100755
--- a/spec/unit/util/network_device/cisco/device_spec.rb
+++ b/spec/unit/util/network_device/cisco/device_spec.rb
@@ -145,7 +145,7 @@ eos
"ATM 0/1.1" => "ATM0/1.1",
"VLAN99" => "VLAN99"
}.each do |input,expected|
- it "should canonicalize #{input} to #{expected}" do
+ it "should canonicalize #{input} to #{expected}", :'fails_on_ruby_1.9.2' => true do
@cisco.canonalize_ifname(input).should == expected
end
end
@@ -232,7 +232,7 @@ eos
@cisco.parse_interface("FastEthernet0/1").should == { :ensure => :absent, :duplex => :auto, :speed => :auto }
end
- it "should be able to parse the sh vlan brief command output" do
+ it "should be able to parse the sh vlan brief command output", :'fails_on_ruby_1.9.2' => true do
@cisco.stubs(:support_vlan_brief?).returns(true)
@transport.stubs(:command).with("sh vlan brief").returns(<<eos)
Switch#sh vlan brief
diff --git a/spec/unit/util/network_device/transport/ssh_spec.rb b/spec/unit/util/network_device/transport/ssh_spec.rb
index 18d22a953..8fc357db3 100755
--- a/spec/unit/util/network_device/transport/ssh_spec.rb
+++ b/spec/unit/util/network_device/transport/ssh_spec.rb
@@ -4,7 +4,7 @@ require File.dirname(__FILE__) + '/../../../../spec_helper'
require 'puppet/util/network_device/transport/ssh'
-describe Puppet::Util::NetworkDevice::Transport::Ssh, :if => Puppet.features.ssh? do
+describe Puppet::Util::NetworkDevice::Transport::Ssh, :if => Puppet.features.ssh?, :'fails_on_ruby_1.9.2' => true do
before(:each) do
@transport = Puppet::Util::NetworkDevice::Transport::Ssh.new()