diff options
| author | Paul Berry <paul@puppetlabs.com> | 2010-11-23 13:19:59 -0800 |
|---|---|---|
| committer | Paul Berry <paul@puppetlabs.com> | 2010-11-23 13:25:58 -0800 |
| commit | 99f4d2fe6c3e9d7483206c0788ba5b3fe9f48454 (patch) | |
| tree | 4901acc5a97375cc70ca765ab7102ac322d2aa87 /spec/unit/provider/service | |
| parent | 3d2fbf604f997e6b9fd94edb96419ffa9869e709 (diff) | |
| download | puppet-99f4d2fe6c3e9d7483206c0788ba5b3fe9f48454.tar.gz puppet-99f4d2fe6c3e9d7483206c0788ba5b3fe9f48454.tar.xz puppet-99f4d2fe6c3e9d7483206c0788ba5b3fe9f48454.zip | |
Maint: made upstart tests more robust.
The tests for the upstart provider were attempting to stub
Process::Status.exitstatus. However, this doesn't work (presumably
because Process::Status is implemented in C). As a result, the
upstart spec tests were failing if the most recent exit code was
nonzero. Changed the tests so that instead of stubbing
Process::Status.exitstatus to return zero, they execute a command that
is known to succeed (`true`).
Paired-with: Jesse Wolfe <jesse@puppetlabs.com>
Diffstat (limited to 'spec/unit/provider/service')
| -rw-r--r-- | spec/unit/provider/service/upstart.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/spec/unit/provider/service/upstart.rb b/spec/unit/provider/service/upstart.rb index 439fd2c79..9fde9e67f 100644 --- a/spec/unit/provider/service/upstart.rb +++ b/spec/unit/provider/service/upstart.rb @@ -24,8 +24,7 @@ describe provider_class do resource = Puppet::Type.type(:service).new(:name => "foo", :provider => :upstart, :status => "/bin/foo") provider = provider_class.new(resource) - Process::Status.any_instance.stubs(:exitstatus).returns(0) - provider.expects(:ucommand) + provider.expects(:ucommand).with { `true`; true } provider.status.should == :running end |