diff options
author | Matt Robinson <matt@puppetlabs.com> | 2011-05-16 16:10:21 -0700 |
---|---|---|
committer | Matt Robinson <matt@puppetlabs.com> | 2011-05-17 09:57:26 -0700 |
commit | 9da1454e71b8330e929ac5616eefa44388c90832 (patch) | |
tree | 8055105961771b9b95a4b888c0599b26000603d6 /spec/unit/parser/functions | |
parent | 47e4ac948504aa6fbd3487ca1b1e19f3c8884a79 (diff) | |
download | puppet-9da1454e71b8330e929ac5616eefa44388c90832.tar.gz puppet-9da1454e71b8330e929ac5616eefa44388c90832.tar.xz puppet-9da1454e71b8330e929ac5616eefa44388c90832.zip |
(#7507) Add ability to filter Ruby 1.9 spec failures
By running:
rspec spec --tag ~@fails_on_ruby_1.9.2
We can now just run the specs that pass under Ruby 1.9. Obviously in
the long term we want to have all the specs passing, but until then we
need notification when we regress. From now on new code will be
required to pass under Ruby 1.9, and Jenkins will give us email
notification if it doesn't or if we break something that was already
working.
Reviewed-by: Daniel Pittman <daniel@puppetlabs.com>
Diffstat (limited to 'spec/unit/parser/functions')
4 files changed, 7 insertions, 7 deletions
diff --git a/spec/unit/parser/functions/create_resources_spec.rb b/spec/unit/parser/functions/create_resources_spec.rb index 88a67e369..da76e75d0 100755 --- a/spec/unit/parser/functions/create_resources_spec.rb +++ b/spec/unit/parser/functions/create_resources_spec.rb @@ -114,7 +114,7 @@ notify{tester:} @scope.resource=Puppet::Parser::Resource.new('class', 't', :scope => @scope) Puppet::Parser::Functions.function(:create_resources) end - it 'should be able to create classes' do + it 'should be able to create classes', :'fails_on_ruby_1.9.2' => true do @scope.function_create_resources(['class', {'bar'=>{'one'=>'two'}}]) @scope.compiler.compile @compiler.catalog.resource(:notify, "test")['message'].should == 'two' @@ -123,7 +123,7 @@ notify{tester:} it 'should fail to create non-existing classes' do lambda { @scope.function_create_resources(['class', {'blah'=>{'one'=>'two'}}]) }.should raise_error(ArgumentError ,'could not find hostclass blah') end - it 'should be able to add edges' do + it 'should be able to add edges', :'fails_on_ruby_1.9.2' => true do @scope.function_create_resources(['class', {'bar'=>{'one'=>'two', 'require' => 'Notify[tester]'}}]) @scope.compiler.compile rg = @scope.compiler.catalog.to_ral.relationship_graph diff --git a/spec/unit/parser/functions/inline_template_spec.rb b/spec/unit/parser/functions/inline_template_spec.rb index a9ac0c2d0..47dcae15e 100755 --- a/spec/unit/parser/functions/inline_template_spec.rb +++ b/spec/unit/parser/functions/inline_template_spec.rb @@ -1,7 +1,7 @@ #!/usr/bin/env rspec require 'spec_helper' -describe "the inline_template function" do +describe "the inline_template function", :'fails_on_ruby_1.9.2' => true do before :all do Puppet::Parser::Functions.autoloader.loadall end diff --git a/spec/unit/parser/functions/shellquote_spec.rb b/spec/unit/parser/functions/shellquote_spec.rb index b100b4913..bfa2969ea 100755 --- a/spec/unit/parser/functions/shellquote_spec.rb +++ b/spec/unit/parser/functions/shellquote_spec.rb @@ -53,7 +53,7 @@ describe "the shellquote function" do result.should(eql( "'$PATH' 'foo$bar' '\"x$\"'")) end - it "should deal with apostrophes (single quotes)" do + it "should deal with apostrophes (single quotes)", :'fails_on_ruby_1.9.2' => true do result = @scope.function_shellquote( ["'foo'bar'", "`$'EDITOR'`"]) result.should(eql( @@ -65,12 +65,12 @@ describe "the shellquote function" do result.should(eql( "'`echo *`' '`ls \"$MAILPATH\"`'")) end - it "should deal with both single and double quotes" do + it "should deal with both single and double quotes", :'fails_on_ruby_1.9.2' => true do result = @scope.function_shellquote( ['\'foo"bar"xyzzy\'', '"foo\'bar\'xyzzy"']) result.should(eql( '"\'foo\\"bar\\"xyzzy\'" "\\"foo\'bar\'xyzzy\\""')) end - it "should handle multiple quotes *and* dollars and backquotes" do + it "should handle multiple quotes *and* dollars and backquotes", :'fails_on_ruby_1.9.2' => true do result = @scope.function_shellquote( ['\'foo"$x`bar`"xyzzy\'']) result.should(eql( '"\'foo\\"\\$x\\`bar\\`\\"xyzzy\'"')) end diff --git a/spec/unit/parser/functions/template_spec.rb b/spec/unit/parser/functions/template_spec.rb index e7ee974d3..6bce69534 100755 --- a/spec/unit/parser/functions/template_spec.rb +++ b/spec/unit/parser/functions/template_spec.rb @@ -1,7 +1,7 @@ #!/usr/bin/env rspec require 'spec_helper' -describe "the template function" do +describe "the template function", :'fails_on_ruby_1.9.2' => true do before :all do Puppet::Parser::Functions.autoloader.loadall end |