Using the Environment class to determine the default environment,

rather than plenty of different places having the logic of how
to determine the default environment.

1 files changed, 140 insertions, 0 deletions

diff --git a/spec/unit/node.rb b/spec/unit/node.rb
new file mode 100755
index 000000000..26aec4196
--- /dev/null
+++ b/spec/unit/node.rb
@@ -0,0 +1,140 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe Puppet::Node, " when initializing" do
+    before do
+        @node = Puppet::Node.new("testnode")
+    end
+
+    it "should set the node name" do
+        @node.name.should == "testnode"
+    end
+
+    it "should not allow nil node names" do
+        proc { Puppet::Node.new(nil) }.should raise_error(ArgumentError)
+    end
+
+    it "should default to an empty parameter hash" do
+        @node.parameters.should == {}
+    end
+
+    it "should default to an empty class array" do
+        @node.classes.should == []
+    end
+
+    it "should note its creation time" do
+        @node.time.should be_instance_of(Time)
+    end
+
+    it "should accept parameters passed in during initialization" do
+        params = {"a" => "b"}
+        @node = Puppet::Node.new("testing", :parameters => params)
+        @node.parameters.should == params
+    end
+
+    it "should accept classes passed in during initialization" do
+        classes = %w{one two}
+        @node = Puppet::Node.new("testing", :classes => classes)
+        @node.classes.should == classes
+    end
+
+    it "should always return classes as an array" do
+        @node = Puppet::Node.new("testing", :classes => "myclass")
+        @node.classes.should == ["myclass"]
+    end
+
+    it "should accept an environment value" do
+        Puppet.settings.stubs(:value).with(:environments).returns("myenv")
+        @node = Puppet::Node.new("testing", :environment => "myenv")
+        @node.environment.should == "myenv"
+    end
+
+    it "should validate the environment" do
+        Puppet.settings.stubs(:value).with(:environments).returns("myenv")
+        proc { Puppet::Node.new("testing", :environment => "other") }.should raise_error(ArgumentError)
+    end
+
+    it "should accept names passed in" do
+        @node = Puppet::Node.new("testing", :names => ["myenv"])
+        @node.names.should == ["myenv"]
+    end
+end
+
+describe Puppet::Node, " when returning the environment" do
+    before do
+        Puppet.settings.stubs(:value).with(:environments).returns("one,two")
+        Puppet.settings.stubs(:value).with(:environment).returns("one")
+        @node = Puppet::Node.new("testnode")
+    end
+
+    it "should return the 'environment' fact if present and there is no explicit environment" do
+        @node.parameters = {"environment" => "two"}
+        @node.environment.should == "two"
+    end
+
+    it "should use the default environment if there is no environment fact nor explicit environment" do
+        env = mock 'environment', :name => :myenv
+        Puppet::Node::Environment.expects(:new).returns(env)
+        @node.environment.should == "myenv"
+    end
+
+    it "should fail if the parameter environment is invalid" do
+        @node.parameters = {"environment" => "three"}
+        proc { @node.environment }.should raise_error(ArgumentError)
+    end
+
+    it "should fail if the parameter environment is invalid" do
+        @node.parameters = {"environment" => "three"}
+        proc { @node.environment }.should raise_error(ArgumentError)
+    end
+end
+
+describe Puppet::Node, " when merging facts" do
+    before do
+        @node = Puppet::Node.new("testnode")
+        Puppet::Node::Facts.stubs(:find).with(@node.name).returns(Puppet::Node::Facts.new(@node.name, "one" => "c", "two" => "b"))
+    end
+
+    it "should prefer parameters already set on the node over facts from the node" do
+        @node.parameters = {"one" => "a"}
+        @node.fact_merge
+        @node.parameters["one"].should == "a"
+    end
+
+    it "should add passed parameters to the parameter list" do
+        @node.parameters = {"one" => "a"}
+        @node.fact_merge
+        @node.parameters["two"].should == "b"
+    end
+
+    it "should accept arbitrary parameters to merge into its parameters" do
+        @node.parameters = {"one" => "a"}
+        @node.merge "two" => "three"
+        @node.parameters["two"].should == "three"
+    end
+end
+
+describe Puppet::Node, " when indirecting" do
+    it "should redirect to the indirection" do
+        @indirection = mock 'indirection'
+        Puppet::Node.stubs(:indirection).returns(@indirection)
+        @indirection.expects(:find).with(:my_node.to_s)
+        Puppet::Node.find(:my_node.to_s)
+    end
+
+    it "should default to the 'null' node terminus" do
+        Puppet::Node.indirection.terminus_class.should == :null
+    end
+
+    after do
+        Puppet::Indirector::Indirection.clear_cache
+    end
+end
+
+describe Puppet::Node do
+    # LAK:NOTE This is used to keep track of when a given node has connected,
+    # so we can report on nodes that do not appear to connecting to the
+    # central server.
+    it "should provide a method for noting that the node has connected"
+end