diff options
author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:12:17 -0700 |
---|---|---|
committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:12:17 -0700 |
commit | 3180b9d9b2c844dade1d361326600f7001ec66dd (patch) | |
tree | 98fe7c5ac7eb942aac9c39f019a17b0b3f5a57f4 /spec/unit/indirector/report/rest_spec.rb | |
parent | 543225970225de5697734bfaf0a6eee996802c04 (diff) | |
download | puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.tar.gz puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.tar.xz puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.zip |
Code smell: Two space indentation
Replaced 106806 occurances of ^( +)(.*$) with
The ruby community almost universally (i.e. everyone but Luke, Markus, and the other eleven people
who learned ruby in the 1900s) uses two-space indentation.
3 Examples:
The code:
end
# Tell getopt which arguments are valid
def test_get_getopt_args
element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")
becomes:
end
# Tell getopt which arguments are valid
def test_get_getopt_args
element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")
The code:
assert_equal(str, val)
assert_instance_of(Float, result)
end
# Now test it with a passed object
becomes:
assert_equal(str, val)
assert_instance_of(Float, result)
end
# Now test it with a passed object
The code:
end
assert_nothing_raised do
klass[:Yay] = "boo"
klass["Cool"] = :yayness
end
becomes:
end
assert_nothing_raised do
klass[:Yay] = "boo"
klass["Cool"] = :yayness
end
Diffstat (limited to 'spec/unit/indirector/report/rest_spec.rb')
-rwxr-xr-x | spec/unit/indirector/report/rest_spec.rb | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/spec/unit/indirector/report/rest_spec.rb b/spec/unit/indirector/report/rest_spec.rb index ce6188334..d0d29f862 100755 --- a/spec/unit/indirector/report/rest_spec.rb +++ b/spec/unit/indirector/report/rest_spec.rb @@ -5,24 +5,24 @@ require File.dirname(__FILE__) + '/../../../spec_helper' require 'puppet/indirector/report/rest' describe Puppet::Transaction::Report::Rest do - it "should be a subclass of Puppet::Indirector::REST" do - Puppet::Transaction::Report::Rest.superclass.should equal(Puppet::Indirector::REST) - end + it "should be a subclass of Puppet::Indirector::REST" do + Puppet::Transaction::Report::Rest.superclass.should equal(Puppet::Indirector::REST) + end - it "should use the :report_server setting in preference to :reportserver" do - Puppet.settings[:reportserver] = "reportserver" - Puppet.settings[:report_server] = "report_server" - Puppet::Transaction::Report::Rest.server.should == "report_server" - end + it "should use the :report_server setting in preference to :reportserver" do + Puppet.settings[:reportserver] = "reportserver" + Puppet.settings[:report_server] = "report_server" + Puppet::Transaction::Report::Rest.server.should == "report_server" + end - it "should use the :report_server setting in preference to :server" do - Puppet.settings[:server] = "server" - Puppet.settings[:report_server] = "report_server" - Puppet::Transaction::Report::Rest.server.should == "report_server" - end + it "should use the :report_server setting in preference to :server" do + Puppet.settings[:server] = "server" + Puppet.settings[:report_server] = "report_server" + Puppet::Transaction::Report::Rest.server.should == "report_server" + end - it "should have a value for report_server and report_port" do - Puppet::Transaction::Report::Rest.server.should_not be_nil - Puppet::Transaction::Report::Rest.port.should_not be_nil - end + it "should have a value for report_server and report_port" do + Puppet::Transaction::Report::Rest.server.should_not be_nil + Puppet::Transaction::Report::Rest.port.should_not be_nil + end end |