maint: Fix order dependent spec failure for face indirection

An indirected face is being created in
spec/unit/application/indirection_base_spec.rb that uses a stubbed out
indirection.  This stub didn't have a name method defined, which caused
the documentation_spec.rb, that does checks against every available
face, to blow up with:

    expected no Exception, got #<NoMethodError: undefined method `to_sym' for nil:NilClass>

in lib/puppet/face/indirector/face.rb when listing the indirections for
the help text.

I toyed with creating a real indirection for the test, but that was
harder than expected.

Paired-with: Max Martin <max@puppetlabs.com>

1 files changed, 2 insertions, 1 deletions

diff --git a/spec/unit/application/indirection_base_spec.rb b/spec/unit/application/indirection_base_spec.rb
index d72def6cf..8a5eee2c6 100755
--- a/spec/unit/application/indirection_base_spec.rb
+++ b/spec/unit/application/indirection_base_spec.rb
@@ -19,7 +19,6 @@ face.instance_variable_set('@version', :current)
 Puppet::Face.register(face)
 ########################################################################
 
-
 describe Puppet::Application::IndirectionBase do
   subject { Puppet::Application::TestIndirection.new }
 
@@ -27,6 +26,8 @@ describe Puppet::Application::IndirectionBase do
     # It would be nice not to have to stub this, but whatever... writing an
     # entire indirection stack would cause us more grief. --daniel 2011-03-31
     terminus = stub_everything("test indirection terminus")
+    terminus.stubs(:name).returns(:testindirection)
+
     Puppet::Indirector::Indirection.expects(:instance).
       with(:testindirection).returns(terminus)