(#7157) Return a non-zero exit code on face failure.

When a face or action fails we should exit non-zero on the CLI to signal this
to our caller.  "Fails" is defined as "raises an exception"; we don't treat
any return value as a significant failure.

Reviewed-By: Jesse Wolf <jesse@puppetlabs.com>

1 files changed, 30 insertions, 0 deletions

diff --git a/spec/lib/puppet/face/basetest.rb b/spec/lib/puppet/face/basetest.rb
index 9a658b685..a98bc382f 100755
--- a/spec/lib/puppet/face/basetest.rb
+++ b/spec/lib/puppet/face/basetest.rb
@@ -1,3 +1,33 @@
+require 'puppet/face'
+
 Puppet::Face.define(:basetest, '0.0.1') do
   summary "This is just so tests don't fail"
+
+  option "--[no-]boolean"
+  option "--mandatory ARGUMENT"
+
+  action :foo do
+    option("--action")
+    when_invoked do |*args| args.length end
+  end
+
+  action :return_true do
+    summary "just returns true"
+    when_invoked do |options| true end
+  end
+
+  action :return_false do
+    summary "just returns false"
+    when_invoked do |options| false end
+  end
+
+  action :return_nil do
+    summary "just returns nil"
+    when_invoked do |options| nil end
+  end
+
+  action :raise do
+    summary "just raises an exception"
+    when_invoked do |options| raise ArgumentError, "your failure" end
+  end
 end