summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorNick Lewis <nick@puppetlabs.com>2011-03-30 16:08:22 -0700
committerNick Lewis <nick@puppetlabs.com>2011-03-30 16:08:22 -0700
commit87ca3130c570df65ab1296cc18de697afa6a55f5 (patch)
tree2b665df75921ddc6794d5959ccd847a1d6ae5373 /lib
parent9d17809e5b240aa80d2c30f4d9625d4812802b8f (diff)
downloadpuppet-87ca3130c570df65ab1296cc18de697afa6a55f5.tar.gz
puppet-87ca3130c570df65ab1296cc18de697afa6a55f5.tar.xz
puppet-87ca3130c570df65ab1296cc18de697afa6a55f5.zip
(#5670) Don't trigger refresh from a failed resource
Resources were triggering their subscribing/notified resources when they failed, which is incorrect. Now, events are only queued if the resource was successful. Paired-With: Max Martin
Diffstat (limited to 'lib')
-rw-r--r--lib/puppet/transaction.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/puppet/transaction.rb b/lib/puppet/transaction.rb
index aa650eea1..48154ad6f 100644
--- a/lib/puppet/transaction.rb
+++ b/lib/puppet/transaction.rb
@@ -47,7 +47,7 @@ class Puppet::Transaction
def apply(resource, ancestor = nil)
status = resource_harness.evaluate(resource)
add_resource_status(status)
- event_manager.queue_events(ancestor || resource, status.events)
+ event_manager.queue_events(ancestor || resource, status.events) unless status.failed?
rescue => detail
resource.err "Could not evaluate: #{detail}"
end