diff options
| author | Daniel Pittman <daniel@puppetlabs.com> | 2011-04-21 10:38:25 -0700 |
|---|---|---|
| committer | Daniel Pittman <daniel@puppetlabs.com> | 2011-04-21 11:47:42 -0700 |
| commit | 03bd5595365b7d541d20ed614e9c8be6a7cba9c9 (patch) | |
| tree | 64ea5660ce34fbfef8488535598501a4cf12dae4 /lib | |
| parent | 7db4793eac52cbbf9c5919597e8e3a6b0a7bbd38 (diff) | |
| download | puppet-03bd5595365b7d541d20ed614e9c8be6a7cba9c9.tar.gz puppet-03bd5595365b7d541d20ed614e9c8be6a7cba9c9.tar.xz puppet-03bd5595365b7d541d20ed614e9c8be6a7cba9c9.zip | |
maint: more robust listing of valid faces.
We used to treat anything with a top level key in the faces hash as a valid
face; it makes more sense to filter that only to things that have at least one
implementation.
Previously we had to be super-careful not to accidentally touch the top level
for an invalid face, which set us up for future failure when someone wasn't
careful enough; now we can cope with that.
Paired-With: Max Martin <max@puppetlabs.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/puppet/interface/face_collection.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/puppet/interface/face_collection.rb b/lib/puppet/interface/face_collection.rb index 591471d4b..49e007ec0 100644 --- a/lib/puppet/interface/face_collection.rb +++ b/lib/puppet/interface/face_collection.rb @@ -24,7 +24,7 @@ module Puppet::Interface::FaceCollection end end end - return @faces.keys + return @faces.keys.select {|name| @faces[name].length > 0 } end def self.validate_version(version) |