summaryrefslogtreecommitdiffstats
path: root/lib/puppet
diff options
context:
space:
mode:
authorLuke Kanies <luke@madstop.com>2007-11-08 15:58:45 -0600
committerLuke Kanies <luke@madstop.com>2007-11-08 15:58:45 -0600
commitba19989c6eab23f3897da20ed8a505ede9198d8b (patch)
tree4175bcb957d0aa74450624b81dd4d27aaad072cb /lib/puppet
parentcf75168dc2f95a530dffb7971733a0db2ef70ba2 (diff)
downloadpuppet-ba19989c6eab23f3897da20ed8a505ede9198d8b.tar.gz
puppet-ba19989c6eab23f3897da20ed8a505ede9198d8b.tar.xz
puppet-ba19989c6eab23f3897da20ed8a505ede9198d8b.zip
Switching the class resource evaluation to only happen
when using :include, not (for example) when evaluating node classes.
Diffstat (limited to 'lib/puppet')
-rw-r--r--lib/puppet/parser/compile.rb11
-rw-r--r--lib/puppet/parser/functions.rb4
2 files changed, 10 insertions, 5 deletions
diff --git a/lib/puppet/parser/compile.rb b/lib/puppet/parser/compile.rb
index 1b58eca42..f23b42a35 100644
--- a/lib/puppet/parser/compile.rb
+++ b/lib/puppet/parser/compile.rb
@@ -83,12 +83,12 @@ class Puppet::Parser::Compile
return @configuration
end
- # FIXME There are no tests for this.
+ # LAK:FIXME There are no tests for this.
def delete_collection(coll)
@collections.delete(coll) if @collections.include?(coll)
end
- # FIXME There are no tests for this.
+ # LAK:FIXME There are no tests for this.
def delete_resource(resource)
@resource_table.delete(resource.ref) if @resource_table.include?(resource.ref)
end
@@ -114,7 +114,7 @@ class Puppet::Parser::Compile
# find, just tag the configuration and move on. This method really just
# creates resource objects that point back to the classes, and then the
# resources are themselves evaluated later in the process.
- def evaluate_classes(classes, scope)
+ def evaluate_classes(classes, scope, lazy_evaluate = true)
unless scope.source
raise Puppet::DevError, "No source for scope passed to evaluate_classes"
end
@@ -126,7 +126,10 @@ class Puppet::Parser::Compile
# of resources.
resource = Puppet::Parser::Resource.new(:type => "class", :title => klass.classname, :scope => scope, :source => scope.source)
store_resource(scope, resource)
- resource.evaluate
+
+ # If they've disabled lazy evaluation (which the :include function does),
+ # then evaluate our resource immediately.
+ resource.evaluate unless lazy_evaluate
@configuration.tag(klass.classname)
found << name
else
diff --git a/lib/puppet/parser/functions.rb b/lib/puppet/parser/functions.rb
index 1d07122d4..a0e8da86f 100644
--- a/lib/puppet/parser/functions.rb
+++ b/lib/puppet/parser/functions.rb
@@ -109,7 +109,9 @@ module Functions
# Include the specified classes
newfunction(:include, :doc => "Evaluate one or more classes.") do |vals|
vals = [vals] unless vals.is_a?(Array)
- klasses = compile.evaluate_classes(vals, self)
+
+ # The 'false' disables lazy evaluation.
+ klasses = compile.evaluate_classes(vals, self, false)
missing = vals.find_all do |klass|
! klasses.include?(klass)