diff options
author | James Turnbull <james@lovedthanlost.net> | 2009-02-14 23:26:12 +1100 |
---|---|---|
committer | James Turnbull <james@lovedthanlost.net> | 2009-02-14 23:27:34 +1100 |
commit | ab847568aabff28450e6bd5280c98c108da0b1f5 (patch) | |
tree | beb22ec6ac0f6b53d7790e8d6d64696c4c472d7a /lib/puppet | |
parent | 7f418579f5b0c5df90ff5ea06294028b8d53f385 (diff) | |
download | puppet-ab847568aabff28450e6bd5280c98c108da0b1f5.tar.gz puppet-ab847568aabff28450e6bd5280c98c108da0b1f5.tar.xz puppet-ab847568aabff28450e6bd5280c98c108da0b1f5.zip |
Cleaned up variable names to be more sane, clarified error messages and fixed incorrect use of 'value' variable rather than 'member'.
Diffstat (limited to 'lib/puppet')
-rw-r--r-- | lib/puppet/provider/nameservice/directoryservice.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/puppet/provider/nameservice/directoryservice.rb b/lib/puppet/provider/nameservice/directoryservice.rb index cb9df2c30..42c52f0a7 100644 --- a/lib/puppet/provider/nameservice/directoryservice.rb +++ b/lib/puppet/provider/nameservice/directoryservice.rb @@ -457,25 +457,25 @@ class DirectoryService < Puppet::Provider::NameService def remove_unwanted_members(current_members, new_members) current_members.each do |member| - if not value.include?(member) + if not new_members.include?(member) cmd = [:dseditgroup, "-o", "edit", "-n", ".", "-d", member, @resource[:name]] begin execute(cmd) rescue Puppet::ExecutionFailure => detail - raise Puppet::Error, "Could not set %s on %s[%s]: %s" % [param, @resource.class.name, @resource.name, detail] + raise Puppet::Error, "Could not remove %s from group: %s, %s" % [member, @resource.name, detail] end end end end def add_members(current_members, new_members) - new_members.each do |user| - if current_members.nil? or not current_members.include?(user) - cmd = [:dseditgroup, "-o", "edit", "-n", ".", "-a", user, @resource[:name]] + new_members.each do |new_member| + if current_members.nil? or not current_members.include?(new_member) + cmd = [:dseditgroup, "-o", "edit", "-n", ".", "-a", new_member, @resource[:name]] begin execute(cmd) rescue Puppet::ExecutionFailure => detail - raise Puppet::Error, "Could not set %s on %s[%s]: %s" % [param, @resource.class.name, @resource.name, detail] + raise Puppet::Error, "Could not add %s to group: %s, %s" % [new_member, @resource.name, detail] end end end |