Exceptions on requests are now captured, exceptions are serialized, and exception text is passed back via REST.

3 files changed, 11 insertions, 5 deletions

diff --git a/lib/puppet/network/http/handler.rb b/lib/puppet/network/http/handler.rb
index 2a537c767..172939538 100644
--- a/lib/puppet/network/http/handler.rb
+++ b/lib/puppet/network/http/handler.rb
@@ -13,6 +13,8 @@ class Puppet::Network::HTTP::Handler
         return do_destroy(request, response)    if delete?(request) and singular?(request)
         return do_save(request, response)       if put?(request) and singular?(request)
         raise ArgumentError, "Did not understand HTTP #{http_method(request)} request for '#{path(request)}'"
+    rescue Exception => e
+        return do_exception(request, response, e)
     end
     
   private
@@ -47,6 +49,10 @@ class Puppet::Network::HTTP::Handler
         encode_result(request, response, result)
     end
   
+    def do_exception(request, response, exception, status=404)
+        encode_result(request, response, exception.to_s, status)
+    end
+  
     def find_model_for_handler(handler)
         Puppet::Indirector::Indirection.model(handler) || 
             raise(ArgumentError, "Cannot locate indirection [#{handler}].")
@@ -98,7 +104,7 @@ class Puppet::Network::HTTP::Handler
         raise NotImplementedError
     end
     
-    def encode_result(request, response, result)
+    def encode_result(request, response, result, status = 200)
         raise NotImplementedError
     end
 end
diff --git a/lib/puppet/network/http/mongrel/rest.rb b/lib/puppet/network/http/mongrel/rest.rb
index f22b4c4c9..db63613ab 100644
--- a/lib/puppet/network/http/mongrel/rest.rb
+++ b/lib/puppet/network/http/mongrel/rest.rb
@@ -29,8 +29,8 @@ class Puppet::Network::HTTP::MongrelREST < Puppet::Network::HTTP::Handler
         Mongrel::HttpRequest.query_parse(request.params["QUERY_STRING"])
     end
     
-    def encode_result(request, response, result)
-        response.start(200) do |head, body|
+    def encode_result(request, response, result, status = 200)
+        response.start(status) do |head, body|
             body.write(result)
         end
     end
diff --git a/lib/puppet/network/http/webrick/rest.rb b/lib/puppet/network/http/webrick/rest.rb
index 8782df14f..dd0c84d61 100644
--- a/lib/puppet/network/http/webrick/rest.rb
+++ b/lib/puppet/network/http/webrick/rest.rb
@@ -34,8 +34,8 @@ class Puppet::Network::HTTP::WEBrickREST < Puppet::Network::HTTP::Handler
         request.query
     end
     
-    def encode_result(request, response, result)
-        response.status = 200
+    def encode_result(request, response, result, status = 200)
+        response.status = status
         response.body = result
     end
 end
\ No newline at end of file