summaryrefslogtreecommitdiffstats
path: root/lib/puppet/util/settings
diff options
context:
space:
mode:
authorJosh Cooper <josh@puppetlabs.com>2011-08-22 09:26:33 -0700
committerJosh Cooper <josh@puppetlabs.com>2011-08-22 15:07:41 -0700
commit0f207a8ea61205ba6b47e8da429ab3887b3cda4d (patch)
tree3dabcf04843f4c4faf4cc35bcdbb3384ee461c73 /lib/puppet/util/settings
parent47058abc0c5647d59b0dd21181e67dbfdd908292 (diff)
downloadpuppet-0f207a8ea61205ba6b47e8da429ab3887b3cda4d.tar.gz
puppet-0f207a8ea61205ba6b47e8da429ab3887b3cda4d.tar.xz
puppet-0f207a8ea61205ba6b47e8da429ab3887b3cda4d.zip
(#8662) Don't manage internal file permissions on Windows
When running as root, puppet will by default manage internal file permissions for file-related settings. However, ruby does not support chown/chgrp functionality on Windows, so puppet will fail to run (puppet apply generates an exception while trying to set the owner, etc). This commit disables internal file permissions handling on Windows until we add support for chown (at least) as part of the larger file type effort on Windows.
Diffstat (limited to 'lib/puppet/util/settings')
-rw-r--r--lib/puppet/util/settings/file_setting.rb3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/puppet/util/settings/file_setting.rb b/lib/puppet/util/settings/file_setting.rb
index 0fa65d846..f02a0c547 100644
--- a/lib/puppet/util/settings/file_setting.rb
+++ b/lib/puppet/util/settings/file_setting.rb
@@ -93,7 +93,8 @@ class Puppet::Util::Settings::FileSetting < Puppet::Util::Settings::Setting
if Puppet[:manage_internal_file_permissions]
resource[:mode] = self.mode if self.mode
- if Puppet.features.root?
+ # REMIND fails on Windows because chown/chgrp functionality not supported yet
+ if Puppet.features.root? and !Puppet.features.microsoft_windows?
resource[:owner] = self.owner if self.owner
resource[:group] = self.group if self.group
end