diff options
author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:12:17 -0700 |
---|---|---|
committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:12:17 -0700 |
commit | 3180b9d9b2c844dade1d361326600f7001ec66dd (patch) | |
tree | 98fe7c5ac7eb942aac9c39f019a17b0b3f5a57f4 /lib/puppet/type/stage.rb | |
parent | 543225970225de5697734bfaf0a6eee996802c04 (diff) | |
download | puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.tar.gz puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.tar.xz puppet-3180b9d9b2c844dade1d361326600f7001ec66dd.zip |
Code smell: Two space indentation
Replaced 106806 occurances of ^( +)(.*$) with
The ruby community almost universally (i.e. everyone but Luke, Markus, and the other eleven people
who learned ruby in the 1900s) uses two-space indentation.
3 Examples:
The code:
end
# Tell getopt which arguments are valid
def test_get_getopt_args
element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")
becomes:
end
# Tell getopt which arguments are valid
def test_get_getopt_args
element = Setting.new :name => "foo", :desc => "anything", :settings => Puppet::Util::Settings.new
assert_equal([["--foo", GetoptLong::REQUIRED_ARGUMENT]], element.getopt_args, "Did not produce appropriate getopt args")
The code:
assert_equal(str, val)
assert_instance_of(Float, result)
end
# Now test it with a passed object
becomes:
assert_equal(str, val)
assert_instance_of(Float, result)
end
# Now test it with a passed object
The code:
end
assert_nothing_raised do
klass[:Yay] = "boo"
klass["Cool"] = :yayness
end
becomes:
end
assert_nothing_raised do
klass[:Yay] = "boo"
klass["Cool"] = :yayness
end
Diffstat (limited to 'lib/puppet/type/stage.rb')
-rw-r--r-- | lib/puppet/type/stage.rb | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/lib/puppet/type/stage.rb b/lib/puppet/type/stage.rb index c11acdcd8..d22cd7b70 100644 --- a/lib/puppet/type/stage.rb +++ b/lib/puppet/type/stage.rb @@ -1,18 +1,18 @@ Puppet::Type.newtype(:stage) do - desc "A resource type for specifying run stages. The actual stage should - be specified on resources:: - class { foo: stage => pre } + desc "A resource type for specifying run stages. The actual stage should + be specified on resources:: + class { foo: stage => pre } - And you must manually control stage order:: + And you must manually control stage order:: - stage { pre: before => Stage[main] } + stage { pre: before => Stage[main] } - You automatically get a 'main' stage created, and by default all resources - get inserted into that stage. + You automatically get a 'main' stage created, and by default all resources + get inserted into that stage. - You can only set stages on class resources, not normal builtin resources." + You can only set stages on class resources, not normal builtin resources." - newparam :name do - desc "The name of the stage. This will be used as the 'stage' for each resource." - end + newparam :name do + desc "The name of the stage. This will be used as the 'stage' for each resource." + end end |