Raising element creation errors up outside the "create" method, so that tests can more easily tell when an object is invalid.

git-svn-id: https://reductivelabs.com/svn/puppet/trunk@1597 980ebf18-57e1-0310-9a29-db15c13687c0

1 files changed, 5 insertions, 3 deletions

diff --git a/lib/puppet/transportable.rb b/lib/puppet/transportable.rb
index 0d775f7e0..90bc70fc2 100644
--- a/lib/puppet/transportable.rb
+++ b/lib/puppet/transportable.rb
@@ -264,9 +264,11 @@ module Puppet
                 end
 
                 # Now just call to_type on them with the container as a parent
-                unless obj = child.to_type(container)
-                    # nothing; we assume the method already warned
-                    #Puppet.warning "Could not create child %s" % child.name
+                begin
+                    child.to_type(container)
+                rescue => detail
+                    # We don't do anything on failures, since we assume it's
+                    # been logged elsewhere.
                 end
             }