Working #3139 - scheduling moved to resource harness

We previously had the schedule checking code in Puppet::Type,
but it's more of a transactional function, and in order to
do proper auditing in the transactional area, we need the
cache checking done there.  Scheduling is one
of the few functions that actually uses cached data currently.

Signed-off-by: Luke Kanies <luke@puppetlabs.com>

1 files changed, 22 insertions, 0 deletions

diff --git a/lib/puppet/transaction/resource_harness.rb b/lib/puppet/transaction/resource_harness.rb
index 76148e69f..05e569b92 100644
--- a/lib/puppet/transaction/resource_harness.rb
+++ b/lib/puppet/transaction/resource_harness.rb
@@ -73,6 +73,28 @@ class Puppet::Transaction::ResourceHarness
         @transaction = transaction
     end
 
+    def scheduled?(resource)
+        return true if Puppet[:ignoreschedules]
+        return true unless schedule = schedule(resource)
+
+        # We use 'checked' here instead of 'synced' because otherwise we'll
+        # end up checking most resources most times, because they will generally
+        # have been synced a long time ago (e.g., a file only gets updated
+        # once a month on the server and its schedule is daily; the last sync time
+        # will have been a month ago, so we'd end up checking every run).
+        return schedule.match?(resource.cached(:checked).to_i)
+    end
+
+    def schedule(resource)
+        unless resource.catalog
+            resource.warning "Cannot schedule without a schedule-containing catalog"
+            return nil
+        end
+
+        return nil unless name = resource[:schedule]
+        resource.catalog.resource(:schedule, name) || resource.fail("Could not find schedule #{name}")
+    end
+
     private
 
     def absent_and_not_being_created?(current, param)